Skip to content

fix: bump action runtime Node 20 → 22.23.4 (security hotfix) - #598

Merged
yeelali14 merged 3 commits into
developfrom
hotfix-bump-node-22.23.4
Oct 26, 2026
Merged

yeelali14 merged 3 commits into
developfrom
hotfix-bump-node-22.23.4

Conversation

@yeelali14

@yeelali14 yeelali14 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Security hotfix for the undici Brotli decompression advisory. The action ran on Node 20.12.2, which is EOL and won't receive the fix.

  • action.yml: setup-node 20.12.2 → 22.23.4
  • .nvmrc: v22.13.0 → v22.23.4
  • package.json / lockfile root engines: >=20 → >=22 (gitstream-core already requires >=22)

Unit tests pass on 22.23.4. This is a major runtime bump for customers, so please smoke-test on a real PR before merging.

Dependency fixes (Orca findings)

  • undici 6.29.0 → 6.29.1 (via @actions/http-client) — CVE-2026-109869
  • follow-redirects 1.16.0 → 1.16.2 (via gitstream-core → axios) — CVE-2026-111755, CVE-2026-111756
  • vendor-plugins now pins follow-redirects@1.16.2: the copy vendored into dist/node_modules for plugins was also 1.16.0 and isn't scanned by Orca (no lockfile); without the pin npm install --prefix dist keeps the existing version.
  • dist rebuilt with npm run bundle on Node 22.23.4; a second rebuild is a no-op (matches Check dist/).

🤖 Generated with Claude Code

✨ PR Description

Purpose: Upgrade the action runtime to Node 22.23.4 as a security hotfix.

Main changes:

  • Updated node-version in action.yml and .nvmrc to 22.23.4
  • Bumped minimum Node engine to >=22 in package.json
  • Updated @linearb/gitstream-core to 2.1.314 and added follow-redirects to vendor-plugins script

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

Node 20 is EOL and will not receive the undici Brotli fix. Also aligns .nvmrc and engines with gitstream-core (>=22).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 14:44

@linearb linearb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

LGTM

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how

Comment thread package-lock.json
Comment thread package-lock.json
Comment thread package-lock.json
@linearb linearb Bot added the 1 min review label Oct 26, 2026

@orca-security-us orca-security-us Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed OSS Licenses high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 3   low 0   info 0 View in Orca
☢️ The following Vulnerabilities (CVEs) have been detected
PACKAGE FILE CVE ID INSTALLED VERSION FIXED VERSION
high follow-redirects ./package-lock.json CVE-2026-111755 1.16.0 1.16.1 View in code
high follow-redirects ./package-lock.json CVE-2026-111756 1.16.0 1.16.1 View in code
high undici ./package-lock.json CVE-2026-109869 6.29.0 6.29.1, 7.30.1, 8.12.2 View in code

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The customer-facing major runtime upgrade still needs confirmation of the real-PR smoke test requested in the description.

No open issues 🎉

What changed in this PR

Updates the action’s Node.js runtime to 22.23.4 for the stated undici Brotli security fix, aligning local development and package requirements with Node.js 22.

Changes:

  • Bumps the action runtime from Node.js 20.12.2 to 22.23.4.
  • Aligns .nvmrc with the action runtime.
  • Raises the minimum Node.js engine requirement to 22 in both package manifests.
File Description
package.json Requires Node.js 22 or later.
package-lock.json Synchronizes the root engine requirement.
action.yml Pins the action runtime to Node.js 22.23.4.
.nvmrc Pins local development to Node.js 22.23.4.

Review effort: Balanced

Fixes Orca findings CVE-2026-109869 (undici) and CVE-2026-111755/111756
(follow-redirects). Also pins follow-redirects in vendor-plugins so the
copy vendored into dist/node_modules is upgraded too; npm otherwise keeps
the already-installed 1.16.0 since it satisfies axios's range.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 14:59

@orca-security-us orca-security-us Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed OSS Licenses high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The customer-facing major runtime upgrade needs the requested real-PR smoke test, whose outcome has not been verified in this review.

No open issues 🎉

Review effort: Balanced

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 15:46
@yeelali14 yeelali14 added the auto-deploy when exists in PR, will auto make release and auto deploy to prod label Oct 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The customer-facing Node.js major-version upgrade needs the requested real-PR smoke test before final approval.

No open issues 🎉

Review effort: Balanced

@yeelali14
yeelali14 merged commit ad50020 into develop Oct 26, 2026
16 checks passed
@yeelali14
yeelali14 deleted the hotfix-bump-node-22.23.4 branch October 26, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 min review auto-deploy when exists in PR, will auto make release and auto deploy to prod 🤖 Claude Code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants