Skip to content

Support async signing for V2 channel establishment - #3411

Closed
jkczyz wants to merge 8 commits into
lightningdevkit:mainfrom
jkczyz:2024-11-async-signing-v2
Closed

Support async signing for V2 channel establishment#3411
jkczyz wants to merge 8 commits into
lightningdevkit:mainfrom
jkczyz:2024-11-async-signing-v2

Remove unnecessary drains from channelmanager.rs

6db89d7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 20, 2026 in 1s

89.23% (+0.01%) compared to 0c31021

View this Pull Request on Codecov

89.23% (+0.01%) compared to 0c31021

Details

Codecov Report

❌ Patch coverage is 66.91176% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.23%. Comparing base (0c31021) to head (6db89d7).
⚠️ Report is 3367 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 64.61% 16 Missing and 7 partials ⚠️
lightning/src/ln/channel.rs 62.50% 20 Missing and 1 partial ⚠️
lightning/src/ln/interactivetxs.rs 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3411      +/-   ##
==========================================
+ Coverage   89.22%   89.23%   +0.01%     
==========================================
  Files         130      130              
  Lines      106965   106958       -7     
  Branches   106965   106958       -7     
==========================================
+ Hits        95438    95446       +8     
+ Misses       8734     8725       -9     
+ Partials     2793     2787       -6

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov