Skip to content

Stop caching every mempool tx for bitcoind #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benthecarman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop caching every mempool tx for bitcoind #1216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/chain/bitcoind.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,15 +1270,16 @@ impl BitcoindClient {

let mempool_entries_cache = mempool_entries_cache.lock().await;
let mut mempool_txs_cache = mempool_txs_cache.lock().await;
mempool_txs_cache.retain(|txid, _| mempool_entries_cache.contains_key(txid));

if let Some(difference) =
mempool_entries_cache.len().checked_sub(mempool_txs_cache.capacity())
{
mempool_txs_cache.reserve(difference)
}
// Only transactions we may have to emit again are cached, i.e., those that entered the
// mempool above our best processed height. Caching every mempool transaction would keep a
// full copy of the mempool in memory.
mempool_txs_cache.retain(|txid, _| {
mempool_entries_cache
.get(txid)
.is_some_and(|entry| entry.height > best_processed_height)
});

let mut txs_to_emit = Vec::with_capacity(mempool_entries_cache.len());
let mut txs_to_emit = Vec::new();
for (txid, entry) in mempool_entries_cache.iter() {
if entry.time > latest_time {
latest_time = entry.time;
Expand All @@ -1302,7 +1303,9 @@ impl BitcoindClient {

match self.get_raw_transaction(&entry.txid).await {
Ok(Some(tx)) => {
mempool_txs_cache.insert(entry.txid, (tx.clone(), entry.time));
if !ancestor_within_height {
mempool_txs_cache.insert(entry.txid, (tx.clone(), entry.time));
}
txs_to_emit.push((tx, entry.time));
},
Ok(None) => {
Expand Down
Loading