Repository navigation
Pin surge-ping to 0.8: 0.9.1 needs 64-bit atomics - #22
Merged
Merged
Conversation
BKPepe
force-pushed
the
deps/surge-ping-32bit
branch
from
September 28, 2026 05:33
c9d2f17 to
08a2aad
Compare
It reaches for AtomicU64, which does not exist where max-atomic-width is 32: 32-bit PowerPC and MIPS, so mpc85xx, ath79 and ramips in OpenWrt. Back to 0.8.4, the version 1.2.0 shipped, until a release has the fix from kolapapa/surge-ping#80.
Nothing here built a target whose max-atomic-width is 32, so surge-ping 0.9.1 reached master without a red job. powerpc-unknown-linux-gnu has that shape, and its binary now also starts under QEMU like the others. 32-bit PowerPC has no 64-bit atomic instruction, so the compiler calls into libatomic. Without linking it the build stays green, but the loader cannot start the binary.
BKPepe
force-pushed
the
deps/surge-ping-32bit
branch
from
November 5, 2026 20:44
08a2aad to
21acce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
surge-ping 0.9.1 reaches for
AtomicU64, which does not exist wheremax-atomic-widthis 32: 32-bit PowerPC and MIPS, so mpc85xx, ath79 and ramips. Fixed in kolapapa/surge-ping#80, which is not released yet, so this pins 0.8.4 until a release has it.Master has failed there since a059533 with
unresolved import std::sync::atomic::AtomicU64. 1.2.0 shipped 0.8.4 and is unaffected. 0.9.1's fixes concern cloned clients and cancelled pings, neither of which this client does. Dependabot'slockfile-onlykeeps it from offering 0.9 back.The new matrix entry builds for
powerpc-unknown-linux-gnuand starts the binary under QEMU, so a dependency like this stops a release instead of breaking OpenWrt afterwards.Checked:
cargo checkon the host and of surge-ping forpowerpc-unknown-linux-gnuwith this lock file. The new CI job itself runs here for the first time in this form.