Skip to content

require patched PHP 8.4.28 and nginx 1.30.7 packages - #614

Closed
ttiot wants to merge 1 commit into
librenms:masterfrom
ttiot:fix/php-nginx-cves
Closed

ttiot wants to merge 1 commit into
librenms:masterfrom
ttiot:fix/php-nginx-cves

Conversation

@ttiot

@ttiot ttiot commented Nov 20, 2026

Copy link
Copy Markdown

The current 26.11.0 image (26.11.0-r1) ships PHP 8.4.27 and nginx 1.30.6, which are both affected by recently disclosed vulnerabilities:

  • PHP 8.4.28 (released 2026-11-19) fixes 14 CVEs that affect the 8.4 branch. They include CVE-2026-129289 (PHP-FPM request smuggling), CVE-2026-115560 and CVE-2026-126714 (session object injection), CVE-2026-129496 (timezone cache use-after-free) and CVE-2026-129291 (PHP-FPM epoll use-after-free). See the php-src security advisories.
  • nginx 1.30.7 fixes CVE-2026-123007 and CVE-2026-123633 (HTTP/2). See the nginx security advisories.

Both fixed versions are already in Alpine 3.24 (php84 8.4.28-r0 and nginx 1.30.7-r0). Because the packages are not pinned, a plain rebuild would pick them up. This PR adds minimum version constraints on nginx, php84 and php84-fpm, so a build cannot silently produce an image with vulnerable packages, and it gives a commit to tag a 26.11.0-r2 release from.

With the default configuration, the bundled nginx does not enable HTTP/2 and does not reuse FastCGI connections (fastcgi_keep_conn), so the most severe issues are not exploitable out of the box. The fixed packages are still worth shipping.

Tested by building the image locally:

$ docker run --rm --entrypoint sh librenms-cvefix:test -c 'php -v | head -1; nginx -v'
PHP 8.4.28 (cli) (built: Nov 20 2026 02:30:25) (NTS)
nginx version: nginx/1.30.7

@ttiot
ttiot requested a review from crazy-max as a code owner November 20, 2026 08:22
@crazy-max

Copy link
Copy Markdown
Member

Closing this because the default configuration blocks the highlighted attack paths, and a rebuild picks up Alpine's updated packages without these version constraints.

We don't enable fastcgi_keep_conn, so the demonstrated PHP-FPM request-smuggling attack isn't exposed. PHP session upload progress is explicitly disabled, blocking the phpAfterShell entry point, and the bundled nginx doesn't enable HTTP/2.

@crazy-max crazy-max closed this Nov 20, 2026
@ttiot

ttiot commented Nov 20, 2026

Copy link
Copy Markdown
Author

Thanks for the quick review, and agreed on the analysis: with the default config none of these paths are reachable.

Would you consider tagging a plain rebuild (e.g. 26.11.0-r2) so the published image picks up php84 8.4.28 and nginx 1.30.7 from Alpine? The current 26.11.0 image still ships 8.4.27 / 1.30.6, so vulnerability scanners keep flagging it, which is a recurring pain for those of us running it in production. No code change needed, of course.

@crazy-max

Copy link
Copy Markdown
Member

I don't plan a release solely to clear scanner findings when the reported attack paths aren't exposed by the default configuration. We'll pick up the updated packages with the next release.

@ttiot

ttiot commented Nov 20, 2026

Copy link
Copy Markdown
Author

Fair enough, thanks for taking the time to answer. We'll pick up the updated packages with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants