Skip to content

Contentnode requisites action skips the permission check #6400

Open

Description

@rtibbles

🙂 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you’re requesting an issue, please:

  • Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don’t follow the guidelines won’t be answered.
  • Confirm that you’ve read the guidelines in your comment.

Overview

The contentnode requisites action finds the node's tree with ContentNode.filter_by_pk rather than get_object(). Any logged-in user can read the prerequisite relationships of a channel tree they can't view, given the id of a node in it.

Complexity: Low
Target branch: hotfixes

Context

  • ContentNodeViewSet.requisites filters PrerequisiteContentRelationship by the tree of the unscoped node.
  • Reproduced: a logged-in user with no access to a private channel gets 200 with every target/prerequisite id pair in its tree from GET /api/contentnode/<id>/requisites.

The Change

Acceptance Criteria

General

  • A logged-in user who can't view the node gets 404 from GET /api/contentnode/<id>/requisites, the same as for a nonexistent id.
  • Editors and viewers of the channel get the same response as before.

Testing

  • Regression tests cover a non-member, a viewer and a nonexistent id.

AI usage

I chose which audit findings belong in #6398 and set the access pattern. Claude Code found and reproduced this gap and drafted this issue.

Activity

  1. added theissue type on Nov 15, 2026
  2. added
    good first issueSelf-contained, straightforward, low-complexity
    help wantedOpen source contributors welcome
    on Nov 15, 2026
  3. learning-equality-bot commented on Nov 15, 2026

    @learning-equality-bot
    Contributor

    Hi! 👋

    This issue is available for contribution and supports self-assignment. Here's how to get started:

    • Comment /assign to assign yourself to this issue
    • You can have up to 2 issues assigned at a time across all community repos
    • Dropping an issue has a 7-day cooldown before the slot opens up
    • Link your pull request to this issue when you submit it

    📖 Read the Contributing guidelines before starting.

    Are you preparing for Google Summer of Code? See our GSoC guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DEV: backendgood first issueSelf-contained, straightforward, low-complexityhelp wantedOpen source contributors welcome

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions