Skip to content

Every IconButton has the accessible name "text" #6378

Open

Description

@rtibblesbot

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Observed behavior

IconButton passes the literal string "text" to KIconButton (ariaLabel="text" with no : binding), so screen readers announce every icon button as "text":

:tooltip="text"
:icon="icon"
ariaLabel="text"

The tooltip receives the translated label, so sighted users see the correct name on hover.

These 12 files use IconButton:

  • channelEdit/components/StudioTree/StudioTree.vue
  • channelEdit/components/ContentNodeEditListItem.vue
  • channelEdit/components/Clipboard/index.vue
  • channelEdit/pages/StagingTreePage/index.vue
  • channelEdit/views/TreeView/index.vue
  • channelEdit/views/CurrentTopicView.vue
  • channelEdit/views/ImportFromChannels/BrowsingCard.vue
  • channelEdit/views/files/EpubRenderer.vue
  • channelEdit/views/files/thumbnails/ContentNodeThumbnail.vue
  • shared/views/channel/ChannelThumbnail.vue
  • administration/pages/Channels/ChannelTable.vue
  • administration/pages/Users/UserTable.vue

User-facing consequences

Screen reader users cannot tell icon buttons apart in the channel editor. For example, the thumbnail field's Generate, Upload, and Crop buttons are all announced as "text".

Steps to reproduce

  1. Open the details of any resource in a channel's edit modal.
  2. Scroll to Thumbnail.
  3. Inspect the icon buttons below the thumbnail: each has aria-label="text".

Context

Studio unstable at 865e06b, Chromium.

Acceptance Criteria

  • Each IconButton has the same accessible name as its tooltip, i.e. its text prop.
  • The thumbnail field's Generate, Upload, and Crop buttons are announced by their labels.
  • A unit test covers the accessible name of IconButton.

AI usage

Claude Code found this during manual QA of #6358, checked IconButton.vue on unstable, and drafted this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions