Skip to content

Members of the Learning Equality code reviewers team are treated as contributors #139

Closed

Description

@bjester

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Observed behavior

The automations treat members of the Learning Equality code reviewers team as community contributors.

For example, pcenov opened learningequality/kolibri#15827. The issue validation workflow posted its contributor greeting and asked rtibblesbot to validate the issue. pcenov is an active member of learning-equality-code-reviewers, so this should not have happened.

#134 changed maintainer detection to use team membership. MAINTAINER_TEAMS in scripts/constants.js lists only these teams:

  • le-admins-team
  • read-only-coding-agents
  • triaging-coding-agents

learning-equality-code-reviewers is not on the list. Team members who are in none of the three teams fail the maintainer check.

Expected behavior

A member of learning-equality-code-reviewers is a maintainer. The automations do not treat them as a contributor on issues, comments, or pull requests.

Steps to reproduce

  1. Use an account that is in learning-equality-code-reviewers and in none of the teams in MAINTAINER_TEAMS.
  2. Open an issue in a repo listed in ISSUE_VALIDATION_REPOS, for example test-actions.
  3. The bot posts the "Thanks for opening this issue!" comment and adds the community-issue-review label.

Deliverables

  • Members of learning-equality-code-reviewers pass the maintainer check in every workflow that uses isContributor or isMaintainer.
  • A test in scripts/is-contributor.test.js covers a user who is only in learning-equality-code-reviewers.
  • docs/testing-automations.md still describes the maintainer teams correctly.

Technical pointers

  • scripts/constants.js: MAINTAINER_TEAMS
  • scripts/utils.js: isMaintainer checks each team with teams.getMembershipForUserInOrg.
  • Callers of the maintainer check:
    • scripts/is-contributor.js, which these workflows use: issue-validation, contributor-issue-comment, contributor-pr-reply, pull-request-label, review-requested, and holiday-message.
    • scripts/pull-request-template.js
    • scripts/update-pr-spreadsheet.js
  • Recognise maintainers by team and comment on template check failures #134 notes an open risk: it did not confirm that the app token can read membership of every team. Check this for the new team too.

AI usage

Claude Code drafted this issue from a maintainer's report. It read the code on main, confirmed pcenov's team membership with the GitHub API, and found the workflows that call the maintainer check.

Activity

  1. rtibblesbot commented on Nov 12, 2026

    @rtibblesbot
    Contributor

    @bjester I can't verify these acceptance criteria in my sandbox. Tick the ones this PR may skip and reply, or reply naming them. A reviewer checks each skipped one on the PR; the rest stay required.

    • The app token can read membership of learning-equality-code-reviewers. — needs a workflow run in a learningequality repo with the bot app's token

    Written by rtibblesbot, an LLM-based coding agent.

  2. bjester commented on Nov 12, 2026

    @bjester
    MemberAuthor

    You can skip verifying the ticked criteria.

  3. bjester commented on Nov 12, 2026

    @bjester
    MemberAuthor

    @rtibblesbot You can skip verifying the ticked criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions