[atiasadir]

Summary

The disk collector currently returns before recording disk-space metrics whenever disk/bytes_used is disabled. Consequently, configuring disk/percent_used alone silently produces no percentage metric.

Allow either disk-space metric to be enabled independently. Preserve the existing labels, partition deduplication, usage retrieval and error logging. Move the existing disk-space recording block into a private method so regression tests can supply a temporary-directory partition without depending on host partition discovery.

Add table-driven regression coverage for bytes-only, percent-only, both and neither, verifying emitted metrics and their label shapes. Document independent percentage-metric configuration.

Reproduction and validation

On upstream HEAD 0370ee485aedc5de21e052e968044e40a39d25cd, the regression test's percent-only case fails because disk_percent_used is absent. It passes with this fix.

• go test -race ./pkg/systemstatsmonitor -count=1
• go vet ./pkg/systemstatsmonitor
• git diff --check
• Linux/amd64 and Windows/amd64 test compilation with CGO_ENABLED=0

Tests were executed on macOS; Linux and Windows checks were compile-only. Full repository tests and golangci-lint were not run.

Special notes for reviewers

This PR was written in part with the assistance of generative AI. The commit message was supplied by the contributor.

This is a locally reproduced configuration defect, not a claim about a production incident. No changes to default metric configuration or exported label schemas are intended.

[linux-foundation-easycla]

• ❌ - login: @atiasadir / name: Adir Atias. The commit (39a7d37) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

[kubernetes-prow]

Welcome @atiasadir!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[kubernetes-prow]

Hi @atiasadir. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiasadir
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment