Skip to content

fix: correct cloud capture and rego policy details - #492

Merged
dangrondahl merged 2 commits into
mainfrom
autopilot/bb6d4a27
Nov 3, 2026
Merged

dangrondahl merged 2 commits into
mainfrom
autopilot/bb6d4a27

Conversation

@mintlify

@mintlify mintlify Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Applies the Claude review findings left on #485 and #486: the skip-tags PUT example now keeps dry run explicit, the Lambda template warning matches its example, and the rego reference covers version pinning and server-side input shape.

Based on #485 and #486.

@mintlify
mintlify Bot requested a review from a team as a code owner November 3, 2026 12:26
@mintlify

mintlify Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
kosli 🟢 Ready View Preview Nov 3, 2026, 12:32 PM

@mintlify
mintlify Bot requested a review from dangrondahl November 3, 2026 12:26
@claude

claude Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @mintlify[bot]'s task in 1m 2s —— View job


Doc review: PR #492 (follow-up on latest push)

Checked git diff 3689550..2341c21 — the only changes are the two sentences flagged in the previous review.

  • Lambda tag collision wording (administration/cloud_capture/getting_started.md:188) — Resolved. Now reads "when a {tag:Key} placeholder is the only part that would tell resources apart," matching the suggested fix; no longer implies any tag placeholder causes a collision.
  • Rego local-input field paths (policy-reference/rego_policy.mdx:407) — Resolved. Added "See Local input data." Verified the anchor resolves: ### Local input data at rego_policy.mdx:415 contains the name→trail_name / flow.name→flow_name mapping table.

No new issues found in the changed lines — 0 new inline comments.

@claude

claude Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Doc review: PR #492

Both new internal links work: /tutorials/working_with_controls#pinning-a-policy-version points to tutorials/working_with_controls.mdx:296, and #trail-moment points to policy-reference/rego_policy.mdx:256. The "dry_run": false added to the PUT example matches what the paragraph at getting_started.md:72 says about it.

administration/cloud_capture/getting_started.md

Improvement: Location: administration/cloud_capture/getting_started.md:188
Issue: The new sentence says the collision "also happens with {tag:Key} placeholders". That reads as if any template using a tag placeholder collides. It doesn't. aws-{region}-{tag:Env} still gives each region's Lambda functions their own name. ECS clusters aren't affected either, because their tags are read. The collision only happens when a {tag:Key} is the only thing that would tell the Lambda environments apart. Line 183 already explains why the tags are empty.
Recommendation: Narrow the sentence. For example: "It also happens when {tag:Key} is the only placeholder that would tell resources apart: tag placeholders are empty for Lambda functions, so aws-{tag:Env} sends every region's Lambda functions into aws."

policy-reference/rego_policy.mdx

Suggestion: Location: policy-reference/rego_policy.mdx:407
Issue: "A policy written for local input may need its field paths changed first" doesn't say which paths change. The answer is in the table under Local input data a few lines further down: name becomes trail_name and flow.name becomes flow_name.
Recommendation: Add a link: "…may need its field paths changed first; see Local input data."


1 Improvement, 1 Suggestion. This review is advisory and nothing blocks the merge.

@dangrondahl
dangrondahl merged commit 0c5d9a8 into main Nov 3, 2026
6 checks passed
@dangrondahl
dangrondahl deleted the autopilot/bb6d4a27 branch November 3, 2026 14:15

This branch was successfully deployed

1 active deployment
staging — 2341c215 Deployed Nov 3, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant