You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: correct cloud capture and rego policy details - #492
Applies the Claude review findings left on #485 and #486: the skip-tags PUT example now keeps dry run explicit, the Lambda template warning matches its example, and the rego reference covers version pinning and server-side input shape.
Checked git diff 3689550..2341c21 — the only changes are the two sentences flagged in the previous review.
Lambda tag collision wording (administration/cloud_capture/getting_started.md:188) — Resolved. Now reads "when a {tag:Key} placeholder is the only part that would tell resources apart," matching the suggested fix; no longer implies any tag placeholder causes a collision.
Rego local-input field paths (policy-reference/rego_policy.mdx:407) — Resolved. Added "See Local input data." Verified the anchor resolves: ### Local input data at rego_policy.mdx:415 contains the name→trail_name / flow.name→flow_name mapping table.
No new issues found in the changed lines — 0 new inline comments.
Both new internal links work: /tutorials/working_with_controls#pinning-a-policy-version points to tutorials/working_with_controls.mdx:296, and #trail-moment points to policy-reference/rego_policy.mdx:256. The "dry_run": false added to the PUT example matches what the paragraph at getting_started.md:72 says about it.
administration/cloud_capture/getting_started.md
Improvement: Location:administration/cloud_capture/getting_started.md:188 Issue: The new sentence says the collision "also happens with {tag:Key} placeholders". That reads as if any template using a tag placeholder collides. It doesn't. aws-{region}-{tag:Env} still gives each region's Lambda functions their own name. ECS clusters aren't affected either, because their tags are read. The collision only happens when a {tag:Key} is the only thing that would tell the Lambda environments apart. Line 183 already explains why the tags are empty. Recommendation: Narrow the sentence. For example: "It also happens when {tag:Key} is the only placeholder that would tell resources apart: tag placeholders are empty for Lambda functions, so aws-{tag:Env} sends every region's Lambda functions into aws."
policy-reference/rego_policy.mdx
Suggestion: Location:policy-reference/rego_policy.mdx:407 Issue: "A policy written for local input may need its field paths changed first" doesn't say which paths change. The answer is in the table under Local input data a few lines further down: name becomes trail_name and flow.name becomes flow_name. Recommendation: Add a link: "…may need its field paths changed first; see Local input data."
1 Improvement, 1 Suggestion. This review is advisory and nothing blocks the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the Claude review findings left on #485 and #486: the skip-tags PUT example now keeps dry run explicit, the Lambda template warning matches its example, and the rego reference covers version pinning and server-side input shape.
Based on #485 and #486.