Skip to content

fix: wrap placeholder in code span so mdx parses existing flows page - #490

Merged
dangrondahl merged 1 commit into
mainfrom
fix/existing-flows-mdx-parse
Nov 3, 2026
Merged

dangrondahl merged 1 commit into
mainfrom
fix/existing-flows-mdx-parse

Conversation

@dangrondahl

Copy link
Copy Markdown
Contributor

Summary

The publishing log for #489 reported:

Failed to parse page content at path implementation_guide/phase_2/plan_organizational_structure/naming_conventions/existing_flows.md: Expected a closing tag for <name> (61:270-61:276) before the end of paragraph

The quoted error message in the Limits section contained a bare <name> placeholder inside double quotes, which MDX reads as an unclosed JSX tag. This wraps the quoted error in a code span, matching the <name>-archived-at-<timestamp> placeholder earlier in the same sentence, which already uses one.

Follow-up to #489.

@dangrondahl
dangrondahl requested a review from a team as a code owner November 3, 2026 10:49
@mintlify

mintlify Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
kosli 🟢 Ready View Preview Nov 3, 2026, 10:50 AM

@claude

claude Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @dangrondahl's task in 29s —— View job


Doc review: PR #490

  • Read the diff and the changed file at HEAD
  • Looked for other bare placeholders and for the same error string on other pages
  • Posted the review

I found nothing worth reporting. Wrapping the quoted error in a code span stops MDX from reading '<name>' as an unclosed JSX tag, so the fix is correct. Outside code spans, the only angle brackets left in existing_flows.md are the intended <Warning>, <Steps> and <Step> components. The error string doesn't appear on any other page.

I didn't run mint broken-links or a local MDX build. The review is in this comment.

@claude

claude Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Doc review

No findings clear the bar. The fix is correct: wrapping the quoted error in a code span stops MDX from reading '<name>' as an unclosed JSX tag, and it matches the existing <name>-archived-at-<timestamp> span. I checked the rest of existing_flows.md at HEAD, and the only angle brackets left outside code spans are the intended <Warning> and <Steps>/<Step> components, so nothing else on this page should break the parse. The error string doesn't appear on any other page.

@dangrondahl
dangrondahl enabled auto-merge (squash) November 3, 2026 10:51
@dangrondahl
dangrondahl merged commit 0bed2ae into main Nov 3, 2026
6 checks passed
@dangrondahl
dangrondahl deleted the fix/existing-flows-mdx-parse branch November 3, 2026 10:55

This branch was successfully deployed

1 active deployment
staging — 56aa6ad6 Deployed Nov 3, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants