You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: wrap placeholder in code span so mdx parses existing flows page - #490
Failed to parse page content at path implementation_guide/phase_2/plan_organizational_structure/naming_conventions/existing_flows.md: Expected a closing tag for <name> (61:270-61:276) before the end of paragraph
The quoted error message in the Limits section contained a bare <name> placeholder inside double quotes, which MDX reads as an unclosed JSX tag. This wraps the quoted error in a code span, matching the <name>-archived-at-<timestamp> placeholder earlier in the same sentence, which already uses one.
Looked for other bare placeholders and for the same error string on other pages
Posted the review
I found nothing worth reporting. Wrapping the quoted error in a code span stops MDX from reading '<name>' as an unclosed JSX tag, so the fix is correct. Outside code spans, the only angle brackets left in existing_flows.md are the intended <Warning>, <Steps> and <Step> components. The error string doesn't appear on any other page.
I didn't run mint broken-links or a local MDX build. The review is in this comment.
No findings clear the bar. The fix is correct: wrapping the quoted error in a code span stops MDX from reading '<name>' as an unclosed JSX tag, and it matches the existing <name>-archived-at-<timestamp> span. I checked the rest of existing_flows.md at HEAD, and the only angle brackets left outside code spans are the intended <Warning> and <Steps>/<Step> components, so nothing else on this page should break the parse. The error string doesn't appear on any other page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The publishing log for #489 reported:
The quoted error message in the Limits section contained a bare
<name>placeholder inside double quotes, which MDX reads as an unclosed JSX tag. This wraps the quoted error in a code span, matching the<name>-archived-at-<timestamp>placeholder earlier in the same sentence, which already uses one.Follow-up to #489.