Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Reviewer's GuideImplementationDelegate non-language confirmations to the existing options handler, preserving its receiver, arguments, and return value while keeping language selection unchanged.
Route language-option arrow-key input through the language cycle while preserving existing handlers for other options.
TestsTest confirmation dispatch for ordinary options, volume wraparound, prior handlers, and isolation of language selection.
Test language arrow-key cycling and preservation of existing handlers for non-language options.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Route the language option's left and right handlers through the existing language cycle instead of the engine's boolean option path. Preserve non-language handlers with their receiver, arguments and return value. Cover persisted language strings, cycle order, boolean/volume controls, and earlier-plugin handler delegation.
Confirmed defect
The translation plugin overrides
Window_Options.processOk, but delegates non-language options toWindow_Command.processOk. This skips the existing options handler, so confirming ordinary boolean and volume options no longer performs their normal updates. Earlier plugins' options handlers are also bypassed.Change
Capture the existing
Window_Options.processOkbefore overriding it, and delegate non-language confirmations with the same receiver, arguments and return value. Keep the language branch unchanged.Only
DynamicTranslation.jsand a new offline regression test change. This standalone fix is based on main83ceac969392e7ea1948652d0b2dd6d06233ddeb; it does not update or combine #5–#8, dependencies, lockfiles or workflows.Validation
git diff --check: passed.npm ci --ignore-scripts --no-audit --no-fundsucceeded using a temporary writable cache; the default cache was unavailable. No build/lint scripts are defined.Head:
5675d19dffb87f37c06e2aac1938a686a94226b4. Hosted CI is pending and must be checked for this exact head.Limits
These are offline fixtures with modeled RPG Maker option handlers, not live MV/MZ UI acceptance. The unchanged development dependency graph still reports 11 vulnerable-package records (3 high, 1 moderate, 7 low); dependency remediation remains separate, including existing #6. No runtime dependency was added. No merge, deployment, release, real game installation or permission changes.
Summary by Sourcery
Restore normal option-handler behavior while retaining the translation plugin’s language selection controls.
Bug Fixes:
Enhancements:
Tests:
Summary by cubic
Fixes the translation plugin's option handling so confirming boolean and volume options still performs their normal updates, and earlier plugins' handlers aren't bypassed. Also keeps language values valid when the language option is changed with the arrow keys.
Window_Options.processOkbefore overriding it and delegates non-language confirmations with the same receiver, arguments, and return value.cursorRightandcursorLefton the language option through the language cycle instead of the engine's boolean option path.Written for commit 93efc16. Summary will update on new commits.
Arrow-key follow-up (2026-11-13)
Head
93efc16a441fcaba1c10d54d48cf9c1749015585also keeps the language option out of the engine's boolean left/right paths, which otherwise savetrueorfalseas the language. Both arrows reuse the existing language cycle; non-language handlers retain their receiver, arguments and return value. Four new tests cover persisted language strings/cycle order and boolean/volume/delegation controls. They produced 2 failures and 2 passes before the fix, then all passed.The final full suite passed 76 Jest tests locally and in both Node 18/20 CI jobs; the Python installer job passed all 27 tests. Syntax checks and whitespace validation passed. The remote head/tree were read back; the tested PR merge-ref tree equals the published tree
af87265c651a1b7afdb4dcdd7db0e7a654e94f70. Dependencies, workflows and prior PRs remain unchanged. These are offline engine-handler fixtures, not live MV/MZ game UI acceptance. The PR remains Draft and unmerged.