Repository navigation
[Automated] Draft docs (kagent): session/lifecycle: support force deletion without suspension - #729
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…etion without suspension Signed-off-by: GitHub Action <action@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target's own content scan fails where the base build passed (docs-theme-extras
markdown-leaks/built-html-integrity):kagent-dev/kagent#3530 — session/lifecycle: support force deletion without suspension
Docs versions:
mainNo code-path rule covers 8 touched file(s). The planner could route these only by identifier search, so the candidate pages may miss what they changed, including in the other mode:
go/api/gen/kagent/api/v1/sessions.pb.gogo/core/internal/controller/scheduledrun/controller.gogo/core/internal/grpcserver/session.gogo/core/internal/service/session/service.gogo/core/internal/service/session/workflow.gogo/core/test/e2e/README.mdWhat changes for users: Session deletion now rejects ordinary delete requests while a turn is submitted or running, unless the caller sets
force. Forced deletion stops active turns, records active tasks as canceled, and deletes the Actor directly without requiring suspension or a final snapshot first.What the docs now say: The Operational considerations page now distinguishes idle expiry from client-requested deletion, shows
kagent agent session delete <session-id> --force, and explains that API callers keepDeleteSessionRequest.sessionIdwhile settingforcetotrue.How
kagent-3530was draftedPlan, and what changed it
operations/operational-considerations.md.DeleteActorbehavior, and task outcomes.Why a documentation change is necessary
The release note says that Session deletion supports force deletion during active turns and no longer requires actor suspension. The Operational considerations page already documents Session expiry and deletion outcomes, but it said active work is never deleted without limiting that claim to idle expiry. A reader deleting a Session from the CLI or API needs to know when ordinary deletion fails, when to use force, and which guards still block deletion.
How to verify this change
kagent agent session delete <session-id>.--force, andkagent agent session get <session-id> -o jsonstill shows the Session inREADY.kagent agent session delete <session-id> --force. A laterkagent agent session get <session-id>returns not found, and the task history records the active task as canceled withSession deleted while the turn was active.Proposed release note
No
proposed-release-note.md:markers.notes_placeableis false. Suggested text: Session deletion supports force deletion during active turns and no longer requires actor suspension.Files in this pull request
docs-site/content/kagent/main/operations/operational-considerations.mdHow the pages were chosen (triage report)
Draft a documentation change
kagent-dev/kagent#3530 — session/lifecycle: support force deletion without suspension
kagent-dev/websitego/api/gen/kagent/api/v1/sessions.pb.gogo/core/internal/controller/scheduledrun/controller.gogo/core/internal/grpcserver/session.gogo/core/internal/service/session/service.gogo/core/internal/service/session/workflow.gogo/core/test/e2e/README.mdDraft branch:
pr-tracker-draft-kagent-3530Important
The test suite has not run on this pull request. It was opened by
github-actions[bot], and GitHub does not start workflows for pull requests opened with the repository's own token. This repository's checks are held asaction_requireduntil somebody presses Approve and run on the Checks tab. Checks that come from GitHub Apps rather than Actions, such as DCO, run on their own.Please approve the checks before reviewing the content: an absence of failures here means the tests have not run, not that they passed.