Repository navigation
feat(helm): expose Service IP-family settings - #3678
Open
kquinsland01 wants to merge 1 commit into
Open
kquinsland01 wants to merge 1 commit into
kquinsland01 wants to merge 1 commit into
Conversation
Signed-off-by: Karl Quinsland <github@karlquinsland.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI and controller can listen on IPv6 while its chart-managed Service remains IPv4-only because the Helm chart does not expose Service IP-family settings.
This is a simple PR to add an optional
ipFamilyPolicyand orderedipFamiliesvalues independently underui.serviceandcontroller.service.Empty defaults omit both fields, preserving Kubernetes defaulting and the chart's existing rendered output.
This also has a bit of documentation explaining how to use any of the three possible configurations: IPv4-only, IPv6-only and dual-stack usage.
Validation:
helm lint helm/kagentpasses.git diff --checkpasses.