Skip to content

helm/metrics: omit reader RBAC for HTTP metrics - #3671

Open
shashankram wants to merge 1 commit into
kagent-dev:mainfrom
shashankram:fix-http-metrics-rbac
Open

shashankram wants to merge 1 commit into
kagent-dev:mainfrom
shashankram:fix-http-metrics-rbac

Conversation

@shashankram

Copy link
Copy Markdown
Contributor

Description

With controller.metrics.enabled=true and config.metrics.secure=false, the chart creates an unused metrics-reader ClusterRole. This prevents installation by namespace-scoped accounts even though HTTP metrics require no authentication or authorization.

  • Render the metrics reader role only for secure metrics.
  • Cover HTTP metrics with rbac.namespaces and global.watchNamespaces scopes.

Change Type

/kind fix

Testing

  • Added Helm regression coverage for HTTP metrics with both namespace settings.
  • Helm lint and 14 chart render comparisons passed.

Changelog

Allow HTTP controller metrics with namespace-scoped installation permissions.

@shashankram
shashankram requested a review from a team as a code owner November 13, 2026 20:38
\# Description

HTTP metrics create an unused ClusterRole, preventing installation by
namespace-scoped accounts.

- Render the metrics reader role only for secure metrics.
- Cover HTTP metrics with explicit and global namespace scopes.

\# Change Type

```
/kind fix
```

\# Changelog

```release-note
Allow HTTP controller metrics with namespace-scoped installation permissions.
```

\# Additional Notes

Signed-off-by: Shashank Ram <shashank.ram@solo.io>
@shashankram
shashankram force-pushed the fix-http-metrics-rbac branch from d4a0bcd to 37bc3e0 Compare November 13, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant