Repository navigation
Conversation
This avoids all the numerical issues associated with tolerances. The paper assumes exact arithmetic, and we already use an epsilon of 1, so we're not really loosing anything here, apart from the ability to use a different epsilon in the future.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 99.64% 99.65%
=======================================
Files 15 15
Lines 1427 1432 +5
=======================================
+ Hits 1422 1427 +5
Misses 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids all the numerical issues associated with tolerances. The paper assumes exact arithmetic, and we already use an epsilon of 1, so we're not really loosing anything here, apart from the ability to use a different epsilon in the future.