Repository navigation
Conversation
…d wait for index Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

masterbranch.go vet ./....go fmt ./....What this PR does
Makes
TestAgentSkillsRoundTripDeleteThenInstallwait for the Skills index, so it is no longer flaky.Root cause of the flakiness: after
jf skills delete --version=1.0.0, the Skills index can still list the deleted version for a short time. The nextinstall --version=1.0.0then tries to download the removed file. It fails with a generic download error instead ofversion '1.0.0' not found/Available versions.Fix:
waitForSkillDeindexed. It polls the Skills versions list (ListSkillVersions, all pages) until the deleted version is gone. This is the index that the install path reads.SkillVersionExistsis not enough: it kept listing the deleted version for more than 90s in CI.assertSkillAbsentand before the failing install.retryWithBackoffSkills. It is bounded byskillsIndexBudget(90s), so it fails with a clear error instead of retrying forever.Do not use
SkillVersionExistsfor this wait. After a delete, it keeps reporting the version for more than 90s. The install path does not use that check. It reads the versions list (ListSkillVersions). That list drops the deleted version in about 4s. Keep the wait on the versions list.Only
agent_skills_test.gochanges. No product code changes.Verification: this change passed on ubuntu and windows in the internal repository CI. It has not run locally against this branch. The public CI will run it.
🤖 Generated with Claude Code