Skip to content

RTECO-2485 - Enable agent skills delete-then-install test with bounded wait for index - #3764

Open
udaykb2 wants to merge 1 commit into
masterfrom
RTECO-2485-skills-delete-then-install
Open

udaykb2 wants to merge 1 commit into
masterfrom
RTECO-2485-skills-delete-then-install

Conversation

@udaykb2

@udaykb2 udaykb2 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

What this PR does

Makes TestAgentSkillsRoundTripDeleteThenInstall wait for the Skills index, so it is no longer flaky.

Root cause of the flakiness: after jf skills delete --version=1.0.0, the Skills index can still list the deleted version for a short time. The next install --version=1.0.0 then tries to download the removed file. It fails with a generic download error instead of version '1.0.0' not found / Available versions.

Fix:

  • Add waitForSkillDeindexed. It polls the Skills versions list (ListSkillVersions, all pages) until the deleted version is gone. This is the index that the install path reads. SkillVersionExists is not enough: it kept listing the deleted version for more than 90s in CI.
  • Call it in the test after assertSkillAbsent and before the failing install.
  • The poll uses the existing retryWithBackoffSkills. It is bounded by skillsIndexBudget (90s), so it fails with a clear error instead of retrying forever.
  • The existing Linux skip (RTECO-2724) stays in place. This PR does not change it.

Do not use SkillVersionExists for this wait. After a delete, it keeps reporting the version for more than 90s. The install path does not use that check. It reads the versions list (ListSkillVersions). That list drops the deleted version in about 4s. Keep the wait on the versions list.

Only agent_skills_test.go changes. No product code changes.

Verification: this change passed on ubuntu and windows in the internal repository CI. It has not run locally against this branch. The public CI will run it.

🤖 Generated with Claude Code

…d wait for index

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@udaykb2
udaykb2 deployed to build-gate November 12, 2026 07:44 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

This branch was successfully deployed

1 active deployment
build-gate — 24258fa3 Deployed Nov 12, 2026 by udaykb2 via Approval gate #1363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant