Repository navigation
fix(docker): chown devbox binary with sudo in DevboxImageDockerfile - #3052
Merged
Merged
Conversation
The GitHub install.sh copies the binary into /usr/local/bin with sudo, so it ends up owned by root. The old get.jetify.com script moved a user-owned temp file into place, which kept the devbox user as owner, so the unprivileged chown that follows used to be a no-op. Now it fails with "Operation not permitted", which broke docker-image-release for 0.21.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
[Low impact] The change appears safe to merge and addresses the reported ownership failure.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker-image-releasefailed for 0.21.0 (run):Cause
#3048 switched the image from
get.jetify.com/devboxto the repo'sinstall.sh. The old script ransudo mvon a temp file thedevboxuser owned, so the installed binary stayed owned bydevbox, and the unprivilegedchownafter it was a no-op. The new script runssudo cpandmv, so the binary is owned by root, and thechown(running asUSER devbox) fails.Fix
Run that
chownwithsudo. Thedevboxuser already has passwordless sudo, set up earlier in the same Dockerfile.DevboxImageDockerfileRootUserruns as root and has nochown, so it isn't affected.Testing
Docker isn't available on the machine this was prepared on, so I haven't built the image locally. After this merges, I'll re-run
docker-image-releaseviaworkflow_dispatchwithtag=0.21.0. That run checks outmain, and the build itself will check the fix.🤖 Generated with Claude Code