Skip to content

Fix CI failures for Coding Style Check #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
softins merged 2 commits into from
Nov 12, 2026
Merged

Fix CI failures for Coding Style Check #3990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eab0a9c
Use ubuntu-24 in coding style check
softins Nov 11, 2026
15936c9
Fetch shfmt from apt instead of snap
softins Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/coding-style-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
# As this action runs with minimal permissions and does not influence the build output,
# we perform no version pinning for the runner or the installed tools here.
# The clangFormatVersion is based on Ubuntu current LTS (jammy at time of writing).
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v7
- name: Check .cpp/.h/.mm with clang-format
Expand All @@ -47,20 +47,22 @@ jobs:

check-bash-style:
name: Verify shell script (Bash) coding style
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
# shellcheck is already pre-installed on ubuntu-latest
steps:
- uses: actions/checkout@v7
- name: Check .sh with shellcheck
run: find -name '*.sh' -not -path './libs/*' -exec shellcheck --shell=bash {} +
- name: Update package index
run: sudo apt-get update
- name: Install shfmt
run: sudo snap install shfmt
run: sudo apt-get -qq install shfmt
- name: Check .sh with shfmt
run: shfmt -d .

check-python-style:
name: Verify Python coding style
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v7
- name: Install pylint
Expand Down
Loading