Repository navigation
Conversation
jaime-jmebot
approved these changes
Nov 8, 2026
jaime-jmebot
left a comment
jaime-jmebot
left a comment
Contributor
There was a problem hiding this comment.
Hi, thanks for putting together the replacement cursor assets. The change cleanly replaces the legacy .cur, .ani, and .ico files with PNG assets, including individual frames for the animated monkey cursor, and records the corresponding sources and authors in the license table. The changed content is asset-only apart from that documentation update, and I don’t see an issue in the reviewed diff. Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request, about deprecating CursorLoader class, in the jmonkeyengine repository: jMonkeyEngine/jmonkeyengine#2742, needs these new assets.