Repository navigation
fix(features): keep signals and pages separate, better entry points - #123
Merged
Merged
Conversation
Found by running 0.8.1 on a real Next.js chat app: Rate Limiting was merged into Caching, Background Jobs and Encryption swallowed the Reminder feature, Message was merged into the Room page, and a scripts/ file was the entry point of Room. - signals only merge with something of the same name - pages merge with entities/capabilities by route resource, entity or name, not by a shared component - entry points: shallowest page first, tooling folders last - scoped package terms match the package; node:crypto and a lone redis import no longer count - tests Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019HJc4sv9pSLh7vhduSUxBE
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Welcome ke DevMap!Terima kasih sudah buat PR. Pastikan checklist ini terpenuhi sebelum review:
CI akan jalan otomatis pada setiap update. Kalau gagal, akan muncul link run di komentar ini. Kalau DevMap membantu, tolong star ya: https://github.com/itsflaid/devmap Terima kasih kontribusinya! 🙏 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up from running 0.8.1 on a real app (
itsflaid/chatme, Next.js + Prisma + tRPC + Upstash). Three features went missing or wrong there:rateLimit.ts), and Background Jobs + Encryption swallowed the Reminder feature (sharedreminders/trigger/route.ts)scripts/generate-room-icons.mjsas its entry point (entry points were picked alphabetically)Fix
scripts/,tools/,bin/last@sentry/nextjs,@trigger.dev) match imports of that package;node:cryptoalone and a loneredisimport no longer mean Encryption / Cachingchatme now lists Authentication, Background Jobs, Encryption, Rate Limiting, Reminder Management, Message Management, Room, Profile, Login, Offline, Privacy and Home.
Verification
pnpm test: 417 pass (4 new)Generated by Claude Code