Repository navigation
Conversation
On a narrow screen the nav collapses to a vertical list, where GitHub, Twitter, the Fediverse account and contact each appeared as a bare glyph. The reader has to know four logos to find the link. The menu now prints a label beside each icon below 46rem, matching the text of the other collapsed entries, and keeps the icons alone on wider screens. The icon spans are marked aria-hidden so the new text is the accessible name.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a narrow screen the navigation collapses to a vertical list, and the four links at the bottom appeared as bare glyphs: a GitHub mark, a Twitter bird, a Mastodon mark and a speech bubble. A reader who does not recognise all four logos has nothing to go on.
This prints a label beside each icon below 46rem, in the same size and weight as the other collapsed entries:
Wider screens are unchanged; the labels are
display: noneabove themobilebreakpoint. The icon spans gainedaria-hidden="true"so the new text is the accessible name rather than needing thetitleattribute.No Ruby toolchain on this machine, so I compiled
css/style.sasswith dart-sass and rendered the menu markup at 487px and 1200px in headless Chromium rather than runningbundle exec jekyll serve.