Repository navigation
Put the CVE-2026-98432 filter on sf and sf2 too - #21
Merged
Merged
Conversation
sf and sf2 (ipni/infra's indexers) run Debian 12 kernels without the fix (6.1.180 and 6.1.135; Debian fixed it in 6.1.190-1), and nothing filtered them. They join the inventory in a group of their own, infra_boxes, which only cve.yml targets: it runs the hardening role's CVE tasks and nothing else. They stay out of ipfs_nodes, where hardening would replace their SSH keys and turn on ufw. They take the shared `user` account on port 5222, through their gateway, and sudo there wants a password, so cve.yml is an operator's run with -K and never CI's. Their mode starts at `count`, set apart from the ipfs_nodes boxes' so they go to enforce on their own schedule. The ruleset path moves from a var on the import to the role's defaults, so tasks_from picks it up; site.yml renders the same paths as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sf and sf2 (ipni/infra's indexers) get the CVE-2026-98432 host filter, in
countmode to start.inventory/hosts.yml: a new group,infra_boxes, withsfandsf2. It is not part ofipfs_nodes.group_vars/infra_boxes/main.yml:ansible_user: user,ansible_port: 5222,cve_2026_98432_mode: count.cve.yml: runs onlyroles/hardening/tasks/cve_2026_98432.ymloninfra_boxes, with sudo, one box at a time, stopping at the first failure.roles/hardening/defaults/main.yml:cve_2026_98432_rulesetmoves here from a var on the import, sotasks_frompicks it up.site.ymlrenders the same paths as before.cve.yml. CI does not apply it.roles/monitoring/defaults/main.ymlare updated.Why
Neither box's kernel has the fix:
Nothing filters inbound traffic on either box.
Why a group of its own
Every playbook and script here targets
ipfs_nodes(or looks a host up by name or IP), soinfra_boxesis picked up by nothing butcve.yml. Putting sf/sf2 inipfs_nodeswould letsite.yml's hardening replace their SSH keys and turn on ufw, which would cut them off.Reviewer notes
useraccount's password, socve.ymlruns with-K. CI has neither the key nor the password, and shouldn't.roles/hardening/tasks/main.yml, sosite.ymlgets its dry run. That dry run should show no change on the ipfs_nodes boxes: the ruleset path is the same, only where it's set moved.--syntax-check.ansible-inventory: sing-1 still getsipnion port 22; sf getsuseron 5222.ansible infra_boxes -m pinganswers from both boxes.cve.yml --check --diff -l sfwith sudo turned off: 0 failed, and the ruleset, unit and directory show as would-change.main. All 7 are the local machine failing to resolve collection modules in roles this PR doesn't touch.After merge
ansible-playbook cve.yml -K --check --diff -l sf, then without--check. The same for sf2.sudo nft list table inet cve_2026_98432for an hour or so.enforceone box at a time throughhost_vars/<box>/, as with sing-1.Follow-ups:
docs/03-monitoring.mdandAGENTS.mdsay ipni/workers doesn't manage sf/sf2's firewalls. They need updating once this merges.🤖 Generated with Claude Code