You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
js: Migrate dialog, snackbar, and stack menu from MDC to MWC - #238
No actionable comments were generated in the recent review.
Summary by CodeRabbit
User Interface
Updated dialogs, notifications, and stack menus to Material Design components while retaining their existing actions and labels.
Stack menus open from their button, adapt to narrow screens, and return focus to the button when closed.
Dialogs provide consistent confirm, cancel, and close behavior.
Bug Fixes
Reopening a notification closes the previous one first, and message length determines how long notifications remain visible.
Improved handling of repeated dialog requests and dialogs closed without confirmation.
Walkthrough
This change replaces MDC dialogs, snackbars, and stack menus with Material Web components. It updates component behavior, styles, dependencies, webpack rules, and UI tests.
Changes
Material Web UI migration
Layer / File(s)
Summary
Material Web build support package.json, webpack.config.js, patzilla-ui/navigator/app/results/results-header.js
Dependencies now use @material/web, and css-loader is upgraded. Webpack adds a CSS style sheet import path and sets font and image asset module types. Unused ripple setup code was removed.
Dialogs now use Material Web slots, actions, and closed-event handling. Snackbars now use a Material Web element and retain the message-length timeout thresholds. Styles and dialog and snackbar test selectors were updated.
Stack menu migration patzilla-ui/navigator/components/stack/*, patzilla-ui/navigator/app/results/results-header.html, patzilla-ui/navigator/style/app.css, tests/ui/ci.ini, tests/ui/stack-menu.spec.js
The stack menu and opener now use Material Web elements. Menu lifecycle, selection handling, anchoring, and reset focus behavior were updated. Styles and test configuration were adjusted, and a test checks repeated Escape-close and focus-return behavior.
sequenceDiagram
participant StackPlugin
participant StackMenuWidget
participant md-menu
participant md-outlined-button
StackPlugin->>StackMenuWidget: Create menu anchored to opener
StackMenuWidget->>md-outlined-button: Focus and set aria-expanded
StackMenuWidget->>md-menu: Call show()
md-menu-->>StackMenuWidget: Emit closed event
StackMenuWidget->>md-outlined-button: Reset aria-expanded
Loading
Possibly related issues
ip-tools/patzilla issue 176 — The issue asks about migrating away from the archived MDC library. This PR migrates dialogs, snackbars, and stack menus, so it addresses part of that scope.
Suggested labels: javascript
Merge Risk: Minimal · up to 5c74c
This change moves dialogs, snackbars and the stack menu to Material Web components. Earlier findings on focus handling and test configuration have been addressed, and no unresolved defects remain from this review.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the three migrated components (dialog, snackbar, stack menu) and the change from MDC to MWC (Material Web). The raw summary confirms these are the main changes: dialog.js, snackbar.js,…
Description check
The description states the PR migrates a few elements to material-web, an implementation of Material Design 3, and references GH-176. This relates directly to the changeset, which replaces MDC dialog,…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the three migrated components (dialog, snackbar, stack menu) and the change from MDC to MWC (Material Web). The raw summary confirms these are the main changes: dialog.js, snackbar.js, and stack-ui.js/stack-menu.html switch from MDC to Material Web elements. The title is specific and matches the changeset.
Full details: Description check
Explanation
The description states the PR migrates a few elements to material-web, an implementation of Material Design 3, and references GH-176. This relates directly to the changeset, which replaces MDC dialog, snackbar, and menu markup and dependencies with @material/web. The description is brief but on-topic.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit taps the menu wide, Then watches dialogs change their stride. A snackbar glows, then closes neat, The buttons bring focus back to seat. The burrow’s UI hops to Web!
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 235e445b-4a7b-47bd-9d67-ddf91a8097ca
Commits
Reviewing files that changed from the base of the PR and between 014b15b and 5c74cff.
Files ignored due to path filters: 1
yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
amotl
changed the title
js: Migrate dialog, snackbar, and stack menu from MDC to Material Web
js: Migrate dialog, snackbar, and stack menu from MDC to MWC
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Migrate a few elements to material-web, an implementation of Material Design 3.
References
material-components-web(MDC) #176