Repository navigation
fix(vue-router): remove parameterized tabs page after switching tabs - #31678
Open
ShryukGrandhi wants to merge 1 commit into
Open
ShryukGrandhi wants to merge 1 commit into
ShryukGrandhi wants to merge 1 commit into
Conversation
Signed-off-by: ShryukGrandhi <85529990+ShryukGrandhi@users.noreply.github.com>
|
@ShryukGrandhi is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30435
What is the current behavior?
When the route that renders
ion-tabshas a parameter (for example/dynamic/:idwith child tabsa,b,c), the view stack identifies the tabs page by the full URL it was first created on, such as/dynamic/123/a.findViewItemByPathrejects any parameterized match whose path isn't exactly equal to the view item's pathname, so after visiting a third tab the leaving view lookup for/dynamic/123/ccan't find the tabs page. Navigating away to/then never transitions the tabs page out, so it stays on top of the new page and blocks it.What is the new behavior?
findViewItemByPathnow compares only the params that belong to the matched route instead of the whole URL./dynamic/123/aand/dynamic/123/cresolve to the same tabs page, while/dynamic/1/aand/dynamic/2/a(and leaf routes like/page/1vs/page/2) still create separate view items as before.tabs.spec.tsthat goes through three tabs of a/dynamic/:idtabs route and then navigates to/. It checks that the home page is visible and the tabs page is hidden.Does this introduce a breaking change?
Other information
Fixes #30435
Testing: I built core,
@ionic/vue, and@ionic/vue-router, then built and synced thevue3test app. The new test failed against the unpatched vue-router build because the home page stayed hidden. With the fix, the full Vitest unit suite passes (12 files, 74 tests).eslintandprettier --checkpass forpackages/vue-router. I didn't run the Cypress and Playwright e2e suites locally.