Skip to content

chore(deps): update test app lock files to resolve security alerts - #31617

Merged
thetaPC merged 6 commits into
mainfrom
test-apps-lockfile-audit-cleanup
Nov 2, 2026
Merged

thetaPC merged 6 commits into
mainfrom
test-apps-lockfile-audit-cleanup

Conversation

@thetaPC

@thetaPC thetaPC commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Issue number: internal


What is the current behavior?

Dependabot and npm audit report most of the repo's alerts against the test app and root lock files. None of them reach users, but they bury real alerts.

What is the new behavior?

  • Updated the vulnerable packages, and the parents that pin them, within the existing ranges in every test app and the root.
  • ng20: npm skips deprecated versions when a non-deprecated one satisfies the range, so @angular/animations and @angular/platform-browser-dynamic held Angular at an early 20.x. Removed @angular/animations, which nothing imports, and raised @angular/platform-browser-dynamic to ^20.1.0. The app now resolves to the latest Angular 20.
  • ng22, ng22-zone and code-split: moved to Angular 22.2.4, and @angular/build and @angular/cli 22.2.5, which pin a patched vite. code-split's exact pins move from 22.0.1. Angular 22.2 renamed the --stats-json output to browser-stats.json, so the test script reads the new file.
  • Angular test apps: the shared require-true validator now imports its @angular/forms types with import type. On Angular 22.2, the webpack dev server rejects value imports of type-only names, which broke the ng22 apps.
  • React and Vue test apps: moved wait-on to v9, which drops its old axios, and added the same compression override as core for serve.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Remaining alerts need a tooling upgrade or have no patch: ng18 and ng19 (Angular versions out of support), lerna 5 in the root, cypress 13, the older vite and vitest in the React apps, and typescript-eslint in ng20.

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Oct 30, 2026 10:21pm UTC

Request Review

@github-actions github-actions Bot added package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package labels Oct 20, 2026
@thetaPC
thetaPC marked this pull request as ready for review October 20, 2026 23:44
@thetaPC
thetaPC requested a review from a team as a code owner October 20, 2026 23:44
@thetaPC
thetaPC requested a review from ShaneK October 20, 2026 23:44
opensource-fork-sync Bot pushed a commit to cla7aye15I4nd/opensource-ionic-team__ionic-framework that referenced this pull request Oct 31, 2026
…#31616)

Issue number: resolves internal

---------

## What is the current behavior?

Dependabot and `npm audit` report high and critical alerts against the
lock files in `core` and `packages/*`. None of them reach users: lock
files are not published, and our declared ranges already resolve to the
patched versions on a fresh install. The alerts are noise that can bury
a real one.

## What is the new behavior?

- Updated the vulnerable packages, and the parents that pin them, within
the existing ranges.
- Added an override in `core` for `compression` under `serve`, since the
latest `serve` pins the vulnerable version. Remove it once a `serve`
release includes vercel/serve#868.
- `migrate` moves to `vite` 7.3.7 rather than the latest 8.x, which
would swap its test bundler for Rolldown.
- Angular dev dependencies move from 22.0 to 22.2. Angular 22.2 dropped
the private `contexts` field from the `ChildrenOutletContexts` typings,
so `ion-router-outlet` now casts to a local type when it saves and
restores tab state. The field still exists at runtime, so behavior is
unchanged.
- `@angular/cli` 22.2 no longer bundles its MCP server, which accounts
for most of the removals in the Angular lock file.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

## Other information

Test app and root lock files are updated in ionic-team#31617. The `postcss` 7
alerts in `core` remain: they come from `stylelint` 13 and need a
`stylelint` upgrade, as noted in ionic-team#31436.

---------

Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>

@OS-jacobbell OS-jacobbell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetaPC
thetaPC added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 163177f Nov 2, 2026
57 checks passed
@thetaPC
thetaPC deleted the test-apps-lockfile-audit-cleanup branch November 2, 2026 23:16

This branch was successfully deployed

1 active deployment
Preview — 795c4c8e Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: react @ionic/react package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants