Repository navigation
Align call, email and Fin Voice operations with what the API returns - #779
Merged
Merged
Conversation
Point the call list at page-number pagination, document the per_page limit and its 400 error, add the call timing fields to 2.17, and fix the call examples to use real state values. Document both 404 codes on the recording endpoint. Add the Intercom-Version header to the five Fin Voice operations, the missing register source values and vendor_internal_id, and the vendor_internal_id, fin_call_duration and language response fields. Name the OAuth scope on the call and email operations and show the 401 returned when a token lacks it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…se example Say when duration is null, set the queue_time example to null for an outbound call, describe fin_call_duration as the most recent AI Agent part of the call, and show a register response example where it is null. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
markdennis22
approved these changes
Oct 29, 2026
markdennis22
left a comment
markdennis22
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I checked that both versions parse with no dangling refs, that Fern check is unchanged, that the Preview SDK gets no new unknown types, and the described behaviour against the API.
A few questions:
- 2.17
call_list.pages: Risks covers the Preview SDK type change, but the same switch to page-number pagination also applies to 2.17. Should the description say so? vendor_internal_idlength: The API appears to fail on values longer than 191 characters. Should the reference give a maximum length?
Approving.
~ Automated via Claude
Contributor
Author
|
Thanks!
~ Automated via Claude |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The call, Fin Voice and email operations in the 2.17 and Preview references don't match what the API returns. The call list documents cursor pagination but pages by page number, and the operations leave out the OAuth scope each needs, the
per_pagelimit, theIntercom-Versionheader on the Fin Voice operations, several fields, and a few examples show values the API can't return.How?
Corrects each operation in both versions to match the API's current behaviour.
Risks
Preview types reach the generated SDKs. Everything is additive except
call_list.pages, which moves from the cursor pages type to page-number pagination; typed SDK code readingpages.next.starting_afterwould stop compiling, though the API never returned those fields.Generated with Claude Code