Repository navigation
Conversation
…catalog The catalog regenerated from plain-metadata.config lists the required characteristics of seven services in another order and lists Name on InputSource and RemoteKey on Television as required. Services instantiate required characteristics in list order, so existing accessories with the default IIDManager got new instance IDs, which HAP requires to stay stable for a pairing. services.json is edited by hand back to the 5.2.0 required lists, so a macOS dry run of the generator should report no changed services. The generator now keeps the previous required list of an existing service in order, adds characteristics the metadata lists as required beyond it as optional, and reports such differences.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #579 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 50 50
Lines 10839 10839
Branches 1404 1404
=======================================
Hits 9972 9972
Misses 579 579
Partials 288 288 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regenerated catalog (#539) lists the required characteristics of seven services in another order and makes Name (InputSource) and RemoteKey (Television) required. With the default IIDManager, existing accessories get new instance IDs, e.g. Mute and Volume of the camera's Microphone swap. This restores the 5.2.0 required lists and makes the generator keep them. A dry run of the generator on macOS should report no changed services.
AI use: written with the help of an AI coding assistant (Fable 5.2). I reviewed and tested the changes myself.