Skip to content

Keep the required characteristics of existing services stable in the catalog - #579

Open
RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:catalog-stable-required
Open

RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:catalog-stable-required

Conversation

@RaHehl

@RaHehl RaHehl commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

The regenerated catalog (#539) lists the required characteristics of seven services in another order and makes Name (InputSource) and RemoteKey (Television) required. With the default IIDManager, existing accessories get new instance IDs, e.g. Mute and Volume of the camera's Microphone swap. This restores the 5.2.0 required lists and makes the generator keep them. A dry run of the generator on macOS should report no changed services.

AI use: written with the help of an AI coding assistant (Fable 5.2). I reviewed and tested the changes myself.

…catalog

The catalog regenerated from plain-metadata.config lists the required
characteristics of seven services in another order and lists Name on
InputSource and RemoteKey on Television as required. Services
instantiate required characteristics in list order, so existing
accessories with the default IIDManager got new instance IDs, which HAP
requires to stay stable for a pairing. services.json is edited by hand
back to the 5.2.0 required lists, so a macOS dry run of the generator
should report no changed services. The generator now keeps the previous
required list of an existing service in order, adds characteristics the
metadata lists as required beyond it as optional, and reports such
differences.
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.00%. Comparing base (412b899) to head (8b80d61).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #579   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files          50       50           
  Lines       10839    10839           
  Branches     1404     1404           
=======================================
  Hits         9972     9972           
  Misses        579      579           
  Partials      288      288           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant