Skip to content

Warn when a changed recording configuration drops the hub's selection - #575

Open
RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:recording-log-dropped-selection
Open

RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:recording-log-dropped-selection

Conversation

@RaHehl

@RaHehl RaHehl commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

When the advertised recording configuration of a paired camera changes, the hub's stored selection is dropped and every recording is refused without a log line. The camera now warns once.

AI use: written with the help of an AI coding assistant (Fable 5.2). I reviewed and tested the changes myself.

When the advertised recording configuration of a paired camera changes,
the hub's stored selection is dropped and every recording is refused
without a log line. The camera now warns once.
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.01%. Comparing base (412b899) to head (25f1d2d).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #575      +/-   ##
==========================================
+ Coverage   92.00%   92.01%   +0.01%     
==========================================
  Files          50       50              
  Lines       10839    10850      +11     
  Branches     1404     1407       +3     
==========================================
+ Hits         9972     9984      +12     
  Misses        579      579              
+ Partials      288      287       -1     
Files with missing lines Coverage Δ
pyhap/camera.py 92.60% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant