Skip to content

Do not arm the recording delegate when a stop overtakes the transport start - #574

Open
RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:recording-transport-start-stop-race
Open

RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:recording-transport-start-stop-race

Conversation

@RaHehl

@RaHehl RaHehl commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

A stop_recording_transport() during start_recording_transport() left the delegate armed and pulling with no port open. The start now checks for that.

AI use: written with the help of an AI coding assistant (Fable 5.2). I reviewed and tested the changes myself.

… start

A stop_recording_transport() during start_recording_transport() left the
delegate armed and pulling with no port open. The start now checks for
that.
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.00%. Comparing base (412b899) to head (d3eae04).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #574   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files          50       50           
  Lines       10839    10841    +2     
  Branches     1404     1405    +1     
=======================================
+ Hits         9972     9974    +2     
  Misses        579      579           
  Partials      288      288           
Files with missing lines Coverage Δ
pyhap/camera.py 92.52% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant