Skip to content

End a running recording when the hub turns recording off or changes its audio - #573

Open
RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:recording-end-when-turned-off
Open

RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:recording-end-when-turned-off

Conversation

@RaHehl

@RaHehl RaHehl commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Turning recording off during a recording made the delegate's recording fail with UNEXPECTED_FAILURE and a traceback, and changing its audio did nothing. Both now close the recording with NOT_ALLOWED, as turning the camera off does.

AI use: written with the help of an AI coding assistant (Fable 5.2). I reviewed and tested the changes myself.

…ts audio

Turning recording off during a recording made the delegate's recording
fail with UNEXPECTED_FAILURE and a traceback, and changing its audio did
nothing. Both now close the recording with NOT_ALLOWED, as turning the
camera off does.
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.00%. Comparing base (412b899) to head (2a89fc3).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #573   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files          50       50           
  Lines       10839    10844    +5     
  Branches     1404     1405    +1     
=======================================
+ Hits         9972     9977    +5     
  Misses        579      579           
  Partials      288      288           
Files with missing lines Coverage Δ
pyhap/camera.py 92.55% <100.00%> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant