Repository navigation
Conversation
…ts audio Turning recording off during a recording made the delegate's recording fail with UNEXPECTED_FAILURE and a traceback, and changing its audio did nothing. Both now close the recording with NOT_ALLOWED, as turning the camera off does.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #573 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 50 50
Lines 10839 10844 +5
Branches 1404 1405 +1
=======================================
+ Hits 9972 9977 +5
Misses 579 579
Partials 288 288
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turning recording off during a recording made the delegate's recording fail with UNEXPECTED_FAILURE and a traceback, and changing its audio did nothing. Both now close the recording with NOT_ALLOWED, as turning the camera off does.
AI use: written with the help of an AI coding assistant (Fable 5.2). I reviewed and tested the changes myself.