Skip to content

Fail a recording that gets no video in time instead of leaving the hub waiting - #572

Open
RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:recording-no-video-timeout
Open

RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:recording-no-video-timeout

Conversation

@RaHehl

@RaHehl RaHehl commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Without usable video, e.g. from an H.264 or a stalled camera, a recording sent and logged nothing until the hub gave up. It now fails after first_video_timeout (10 s), and the hub is told.

AI use: written with the help of an AI coding assistant (Fable 5.2). I reviewed and tested the changes myself.

…b waiting

Without usable video, e.g. from an H.264 or a stalled camera, a
recording sent and logged nothing until the hub gave up. It now fails
after first_video_timeout (10 s), and the hub is told.
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.01%. Comparing base (412b899) to head (98731ed).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #572      +/-   ##
==========================================
+ Coverage   92.00%   92.01%   +0.01%     
==========================================
  Files          50       50              
  Lines       10839    10852      +13     
  Branches     1404     1404              
==========================================
+ Hits         9972     9986      +14     
+ Misses        579      578       -1     
  Partials      288      288              
Files with missing lines Coverage Δ
pyhap/media/recording_delegate.py 88.20% <100.00%> (+0.84%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant