Skip to content

Leave media from before an outage out of a recording's prebuffer - #571

Open
RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:prebuffer-drop-stale
Open

RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:prebuffer-drop-stale

Conversation

@RaHehl

@RaHehl RaHehl commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

After the camera's media stopped, the prebuffer kept its last seconds, so a recording started with stale frames and then nothing. Media from before such a pause is now left out.

AI use: written with the help of an AI coding assistant (Fable 5.2). I reviewed and tested the changes myself.

After the camera's media stopped, the prebuffer kept its last seconds,
so a recording started with stale frames and then nothing. Media from
before such a pause is now left out.
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.02%. Comparing base (412b899) to head (6211bf1).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #571      +/-   ##
==========================================
+ Coverage   92.00%   92.02%   +0.02%     
==========================================
  Files          50       50              
  Lines       10839    10845       +6     
  Branches     1404     1405       +1     
==========================================
+ Hits         9972     9980       +8     
+ Misses        579      578       -1     
+ Partials      288      287       -1     
Files with missing lines Coverage Δ
pyhap/media/recording.py 90.15% <100.00%> (+0.81%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant