Skip to content

Stop the recording in the worker when its start is cancelled - #570

Open
RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:recorder-start-cancelled
Open

RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:recorder-start-cancelled

Conversation

@RaHehl

@RaHehl RaHehl commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

When the hub closed a recording right after opening it, the worker's transcoder kept running and every later recording failed with "A recording runs already". A cancelled start now stops it.

AI use: written with the help of an AI coding assistant (Fable 5.2). I reviewed and tested the changes myself.

When the hub closed a recording right after opening it, the worker's
transcoder kept running and every later recording failed with "A
recording runs already". A cancelled start now stops it.
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.04%. Comparing base (412b899) to head (6578e4a).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #570      +/-   ##
==========================================
+ Coverage   92.00%   92.04%   +0.04%     
==========================================
  Files          50       50              
  Lines       10839    10844       +5     
  Branches     1404     1405       +1     
==========================================
+ Hits         9972     9981       +9     
+ Misses        579      576       -3     
+ Partials      288      287       -1     
Files with missing lines Coverage Δ
pyhap/media/recording.py 89.81% <100.00%> (+0.47%) ⬆️
pyhap/media/worker.py 84.05% <100.00%> (+0.49%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant