Skip to content

Resolve mDNS candidates of a WebRTC answer with the driver's Zeroconf - #569

Open
RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:mdns-driver-zeroconf
Open

RaHehl wants to merge 1 commit into
ikalchev:devfrom
RaHehl:mdns-driver-zeroconf

Conversation

@RaHehl

@RaHehl RaHehl commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

The media transport created and closed its own AsyncZeroconf to resolve .local candidates. In Home Assistant that closes the shared instance and all of its services. The WebRTC delegate now resolves them with the driver's instance before it applies the answer, waiting at most 2 s, and names that do not resolve are ignored. Adds StreamSession.camera.

AI use: written with the help of an AI coding assistant (Fable 5.2). I reviewed and tested the changes myself.

The media transport created and closed its own AsyncZeroconf to resolve
.local candidates. In Home Assistant that closes the shared instance and
all of its services. The WebRTC delegate now resolves them with the
driver's instance before it applies the answer, waiting at most 2 s, and
names that do not resolve are ignored. Adds StreamSession.camera.
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.25373% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.19%. Comparing base (412b899) to head (6ac63cf).

Files with missing lines Patch % Lines
pyhap/media/sender.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #569      +/-   ##
==========================================
+ Coverage   92.00%   92.19%   +0.19%     
==========================================
  Files          50       51       +1     
  Lines       10839    10918      +79     
  Branches     1404     1414      +10     
==========================================
+ Hits         9972    10066      +94     
+ Misses        579      562      -17     
- Partials      288      290       +2     
Files with missing lines Coverage Δ
pyhap/camera_stream.py 98.03% <100.00%> (+0.43%) ⬆️
pyhap/media/_mdns.py 100.00% <100.00%> (ø)
pyhap/media/ice.py 86.88% <ø> (+2.87%) ⬆️
pyhap/media/transport.py 88.97% <100.00%> (+0.27%) ⬆️
pyhap/media/webrtc_delegate.py 97.58% <100.00%> (+0.10%) ⬆️
pyhap/media/sender.py 89.84% <83.33%> (-0.10%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant