Skip to content

Improve CI test discovery, parallel checks, and dependency updates - #752

Merged
binaryfire merged 14 commits into
0.4from
phpstan/test-double-strictness
Nov 18, 2026
Merged

binaryfire merged 14 commits into
0.4from
phpstan/test-double-strictness

Conversation

@binaryfire

@binaryfire binaryfire commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Test discovery

A package test that needed to run on every database used to need a subclass in each driver's directory. Now a single test in tests/Integration/{Package}/Database/ runs on MySQL, MariaDB, PostgreSQL, and SQLite. Tests in a driver subdirectory still run on that driver. The database job selects both sets in one ParaTest run. The NestedSet schema tests also run on MySQL 5.7. The tree tests that use window functions still require MySQL 8.

Redis, Valkey, and Redis Cluster now discover tests/Integration/{Package}/Redis/ the same way. Redis and Valkey share a runner, which also picks up the Permission and Reverb coverage that Valkey was missing. Cluster runs serially because its tests share database zero.

CI and static analysis

Framework tests and package tests can now run in parallel jobs on each supported PHP version. Code style and skeleton configuration run once. The Testbench sample package also resolves the local checkout when CI runs on a feature branch.

composer analyse:tests checks that a test chooses strict() or passthru() before using a Double. A test that intentionally relies on lenient behavior can say why at the call site. The rule runs in its own static analysis job and is opt-in for users of the PHPStan package.

Dependency updates

The workflows use GitHub's native Actions lockfile. The migration preserves the action commits we already use, while letting the workflow files refer to readable release tags. A separate check verifies the lockfile on pull requests and pushes to 0.4. Dependabot updates the tags and lockfile together.

Components, the application skeleton, and the standalone dogfood projects now wait three days before resolving a newly published Composer release, matching our pnpm policy. Installs from an existing lockfile keep their recorded versions. The CI image pulls the latest stable Composer at build time so fresh installs honor the policy.

Verification

Compared database and Redis test discovery with the previous workflows and ran the affected suites against the supported backends. Verified the Actions lockfile, checked that a missing workflow entry fails verification, and tested fresh Composer resolution for each project that sets the cooldown.

View guided diff Turn on auto-fix

Note

Split CI jobs into parallel matrices and add test-only PHPStan rule

  • Reworks tests.yml into separate parallel jobs: code style on PHP 8.4 only, framework tests and package tests each on a PHP 8.4/8.5 shared matrix
  • Adds RequireExplicitDoubleModeRule, a PHPStan rule that reports Double::for factories without an explicit strict() or passthru() mode, wired through the new phpstan.tests.neon.dist config and composer analyse:tests
  • Consolidates database-specific integration test wrappers into a shared Database directory, with RequiresDatabase attributes declaring MySQL, MariaDB, and PostgreSQL coverage; PHPUnit gains a default suite and driver-specific mysql, mariadb, pgsql, and sqlite suites in phpunit.xml.dist
  • Replaces GitHub Actions commit SHAs with version tags across workflows and adds a lockfile verification job using the new actions.lock
  • Adds a three-day policy.cooldown.period to Composer configs and pins Composer 2.11+ in the CI Docker image
  • Behavioral Change: several integration tests now run against more databases (e.g. NestedSet and RateLimiter tests on PostgreSQL); NodeTest still excludes MySQL. CI runtime layout changes — check the matrix definitions in tests.yml

Macroscope summarized e4c1c3b.

Report a Double factory call when the test can use the double before choosing strict or passthru mode. Follow chained factories, conditional results and split setup in the same statement list. Configuring expectations before selecting a mode is valid.

Exercise these cases in a rule fixture, including reassignments, conditional mode changes and first-class callables. Leave registration to the test analysis configuration so consumers can opt in independently.
Add a dedicated test analysis configuration and result cache, and include the command in the local analyse script. Exclude inputs that exercise PHPStan itself while keeping the executable analyzer tests in scope.

Use identifier-specific ignores in the two tests that deliberately accept unrelated calls. Their existing explanations now sit next to the diagnostic they suppress.
Show packages how to enable the rule in a test configuration and document intentional leniency at the factory call. Point contributors to the test-only Composer command and distinguish it from normal source analysis.

Align the documented PHPStan minimum with the package requirement of 2.3.6.
The root package replaces hypervel/support with its own version. On a feature branch Composer reports a dev branch name, which supports equality but does not satisfy ordered constraints against itself.

Keep the replaced-package equality checks and exercise the ordering operators against the exact numeric version of psr/clock-implementation. The existing cases for wildcard and union constraints still run.
Give the path repository the 0.4.x-dev version required by the sample package. Otherwise a feature branch takes precedence over Packagist but has a dev branch name that cannot satisfy the requirement.

This follows the AI and MCP samples and lets a clean install exercise the current checkout.
Run the framework and Permission suites independently of the PHPStan, Testbench and sample package suites. Share the PHP 8.4 and 8.5 matrix so both groups exercise the same runtimes.

Run the code style and skeleton configuration checks once on PHP 8.4. They use the same inputs on both versions and no longer delay the runtime tests.
Add phpstan.tests.neon.dist to the existing PHP 8.4 configuration matrix. This applies the test-authoring rule to the same source once, while the PHPStan extension’s PHPUnit suite runs on both supported PHP versions.
Move the exact commits for the ten external actions used across our
twenty workflows into GitHub's native actions.lock. Use the corresponding
release tags in workflow files so version changes are easy to review.
Dependabot can update those tags and their pins in the same grouped PR
under the existing weekly schedule and five-day cooldown.

Verify the lockfile on every pull request and on pushes to 0.4 in a
single read-only job outside the PHP matrix. This catches missing pins
when a workflow is added, even if another workflow already uses the same
action. Install a pinned version of the verifier so the check itself
uses a known release.
Run tests/Integration/<Package>/Redis in the Redis, Valkey and Redis
Cluster jobs so adding a package suite no longer requires editing three
lists. Redis and Valkey share the standalone ParaTest command with its
15-worker cap. Cluster uses serial PHPUnit because its tests share
database zero.

Keep the whole Cache, Horizon and Queue suites and their existing
driver settings. Run Permission with the Redis cache store on both
standalone backends, closing a gap in the Valkey job. Keep the narrower
core Redis selection for Cluster.

Move the three Reverb tests that need only Redis into Reverb/Redis. This
adds shared-state and webhook-buffer coverage on Valkey while preserving
the dedicated Reverb workflow and the clear-state command's Cluster
skip. Document the directory convention and how to run filtered suites
locally.
Run tests directly under each package's Database directory on MySQL,
MariaDB, PostgreSQL and SQLite. Pair the shared PHPUnit suite with the
matching driver suite in one ParaTest invocation so files can run in
parallel across packages. Keep the existing default PHPUnit suite for
ordinary framework runs.

Replace driver wrappers that only inherited the same assertions with
concrete package tests. Keep method-level requirements for driver-specific
assertions and separate SQLite subclasses where the tests require a
file-backed database or a controlled clock.

Keep the NestedSet tree suites gated on MySQL 8 for their window
functions. Run the schema tests on MySQL 5.7 as well, since they only
exercise columns and indexes. All five schema tests passed on MySQL
5.7.44. Compared discovery against the previous selections for all four
drivers and ran focused suites on MariaDB, PostgreSQL and SQLite.
Show where shared database tests, driver-specific tests, and Redis tests belong. Keeping shared assertions in one concrete class avoids creating empty subclasses for each driver.

Clarify that suites outside these conventions need registration in their workflow or its runner. Remove the blanket instruction to edit a workflow for every new directory.
Give newly published releases three days before the Components development checkout, new Hypervel applications, and standalone dogfood projects can resolve them. This matches the pnpm minimum release age. Each project sets the policy in its own root manifest because Composer ignores configuration supplied by dependencies.

Pull the latest stable Composer binary when building the CI image. The base image ships Composer 2.10.3, which accepts the configuration but does not enforce the cooldown. The existing weekly image rebuild keeps the tool current without updating it in each test job.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Deploying hypervel-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: e4c1c3b
Status:🚫  Build failed.

View logs

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@binaryfire

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Action not completed

Review skipped: 121 files exceed the limit of 100.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

PR Summary by Qodo

Discover shared integration tests and parallelize CI checks

✨ Enhancement 🧪 Tests ⚙️ Configuration changes 📝 Documentation 🕐 40+ Minutes

Grey Divider

AI Description

• Discover shared database and Redis tests across supported backends without per-driver wrapper
 classes.
• Split CI checks by purpose and add an opt-in PHPStan rule for explicit Double modes.
• Lock Actions tags to reviewed commits and delay fresh Composer dependency resolution by three
 days.
Merge Risk 🟡 Medium

Blast radius 🔴 High 💥 3 capabilities

  • 3 affected capabilities span independent functional scopes: ci_infrastructure, composer_dependency_policy, test_static_analysis.
  • The skeleton, root and dogfood composer files all set the same policy for dependency resolution.
  • This is one bounded behavior.
  • The rule only affects PHPStan analysis of test code in projects that opt in.
  • All of these changes affect how CI runs and which tests it covers.
Behavioral complexity 🟡 Medium 🧩 Interacting branches, Data transformation

  • Before: there was no rule.
  • After: the rule follows factory results through ternaries, match arms, assignments and later statements, and the order of mode calls, argument evaluation and nullsafe short-circuiting all matter.
  • New correctness condition: the factory result is cleared only when a mode call is guaranteed to run before the first use.
Potential damage 🟡 Medium 🩹 Recoverable

  • CI coverage could regress, or an action could be compromised.
  • The new actions.lock file and verify job (excluded from my view) may mitigate this.
  • Workflows can be reverted.
  • A compromised action's side effects, such as pushed tags or releases, would need manual remediation.
Assessed commit e4c1c3b
Diagram

graph TD
  CI["CI workflows"] --> DB["Database runner"] --> DS["PHPUnit suites"] --> DT["Database tests"]
  CI --> RR["Redis runner"] --> RT["Redis tests"]
  CI --> PA["Test analysis"]
  CI --> AL["Actions lockfile"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Discover database files in shell
  • ➕ Could avoid adding PHPUnit suites to the default configuration.
  • ➖ Would duplicate test-selection rules outside PHPUnit and complicate a single ParaTest invocation.

Recommendation: Keep database selection in PHPUnit suites and Redis service-specific selection in its runner. That gives databases one ParaTest invocation while retaining Redis Cluster’s necessary serial execution; review suite membership and backend-specific skips carefully.

Files changed (65) +778 / -235

Enhancement (1) +222 / -0
RequireExplicitDoubleModeRule.phpDetect Doubles used without an explicit mode +222/-0

Detect Doubles used without an explicit mode

• Adds a PHPStan rule that follows factory results through chains, conditional expressions, and same-list assignments, reporting factories not configured with strict() or passthru().

src/phpstan/src/Rules/Testing/RequireExplicitDoubleModeRule.php

Tests (29) +220 / -42
AuthEloquentUserProviderCacheTest.phpExplain intentionally lenient store validation +1/-1

Explain intentionally lenient store validation

• Adds an identifier-specific PHPStan ignore beside the Double factory that intentionally accepts unrelated calls.

tests/Auth/AuthEloquentUserProviderCacheTest.php

ConversationConcurrencyTest.phpRun shared AI concurrency coverage directly +3/-1

Run shared AI concurrency coverage directly

• Makes the test concrete and limits it to MySQL, MariaDB, and PostgreSQL without driver wrapper classes.

tests/Integration/Ai/Database/ConversationConcurrencyTest.php

ConversationStorageTest.phpRun shared AI storage coverage directly +3/-1

Run shared AI storage coverage directly

• Makes the test concrete and declares its supported SQL drivers.

tests/Integration/Ai/Database/ConversationStorageTest.php

EloquentUserProviderCacheTest.phpRun auth database-cache tests directly +1/-1

Run auth database-cache tests directly

• Makes the previously abstract shared test discoverable on each database.

tests/Integration/Auth/Database/EloquentUserProviderCacheTest.php

NestedSetSchemaTest.phpShare NestedSet schema coverage across SQL drivers +2/-2

Share NestedSet schema coverage across SQL drivers

• Places the test in the shared database namespace and enables MySQL, MariaDB, and PostgreSQL, including MySQL 5.7.

tests/Integration/NestedSet/Database/NestedSetSchemaTest.php

NodeTest.phpShare NestedSet node coverage +2/-2

Share NestedSet node coverage

• Moves the test to the shared database namespace and selects MariaDB and PostgreSQL.

tests/Integration/NestedSet/Database/NodeTest.php

NodeUuidTest.phpShare UUID node coverage +2/-2

Share UUID node coverage

• Moves the test to the shared database namespace and selects MariaDB and PostgreSQL.

tests/Integration/NestedSet/Database/NodeUuidTest.php

ScopedNodeTest.phpShare scoped node coverage +2/-2

Share scoped node coverage

• Moves the test to the shared database namespace and selects MariaDB and PostgreSQL.

tests/Integration/NestedSet/Database/ScopedNodeTest.php

ScopedNodeUuidTest.phpShare scoped UUID node coverage +2/-2

Share scoped UUID node coverage

• Moves the test to the shared database namespace and selects MariaDB and PostgreSQL.

tests/Integration/NestedSet/Database/ScopedNodeUuidTest.php

PasskeyCredentialIdTest.phpRun passkey credential coverage directly +1/-1

Run passkey credential coverage directly

• Makes the shared credential-ID test concrete so all database suites can discover it.

tests/Integration/Passkeys/Database/PasskeyCredentialIdTest.php

GrantConcurrencyTest.phpShare Passport grant concurrency coverage +3/-1

Share Passport grant concurrency coverage

• Makes the test concrete and restricts execution to MySQL, MariaDB, and PostgreSQL.

tests/Integration/Passport/Database/GrantConcurrencyTest.php

PassportSchemaTest.phpConsolidate Passport schema tests +36/-1

Consolidate Passport schema tests

• Makes the shared schema test concrete and moves the large-offset mutation assertion into a MySQL-only method.

tests/Integration/Passport/Database/PassportSchemaTest.php

TokenPersistenceTest.phpRun Passport token persistence coverage directly +1/-1

Run Passport token persistence coverage directly

• Makes the shared token-persistence test concrete for database-suite discovery.

tests/Integration/Passport/Database/TokenPersistenceTest.php

OutboxClaimTest.phpDiscover shared SQL outbox claim tests +12/-0

Discover shared SQL outbox claim tests

• Adds one concrete test class for MySQL, MariaDB, and PostgreSQL; SQLite retains its driver-specific class.

tests/Integration/Queue/Database/OutboxClaimTest.php

OutboxClaimTestCase.phpPlace the outbox test base beside its database tests +1/-1

Place the outbox test base beside its database tests

• Changes the base class namespace to match its database test directory.

tests/Integration/Queue/Database/OutboxClaimTestCase.php

OutboxClaimTest.phpRetain SQLite-specific outbox coverage +1/-1

Retain SQLite-specific outbox coverage

• Updates the SQLite test’s base-class import after its namespace changes.

tests/Integration/Queue/Database/Sqlite/OutboxClaimTest.php

DatabaseStoreTest.phpShare SQL rate-limiter coverage +2/-3

Share SQL rate-limiter coverage

• Moves the test to the shared database namespace and selects MySQL, MariaDB, and PostgreSQL.

tests/Integration/RateLimiter/Database/DatabaseStoreTest.php

ClearStateCommandTest.phpPlace Reverb clear-state coverage under Redis +1/-1

Place Reverb clear-state coverage under Redis

• Changes the test namespace to match its Redis integration directory.

tests/Integration/Reverb/Redis/ClearStateCommandTest.php

RedisSharedStateTest.phpPlace Reverb shared-state coverage under Redis +1/-1

Place Reverb shared-state coverage under Redis

• Changes the test namespace to match Redis-directory discovery.

tests/Integration/Reverb/Redis/RedisSharedStateTest.php

WebhookBatchBufferTest.phpPlace Reverb webhook coverage under Redis +1/-1

Place Reverb webhook coverage under Redis

• Changes the test namespace to match Redis-directory discovery.

tests/Integration/Reverb/Redis/WebhookBatchBufferTest.php

PersonalAccessTokenCacheTest.phpRun Sanctum token-cache coverage directly +1/-1

Run Sanctum token-cache coverage directly

• Makes the shared database test concrete instead of relying on driver wrappers.

tests/Integration/Sanctum/Database/PersonalAccessTokenCacheTest.php

PersonalAccessTokenExpiryTest.phpRun Sanctum token-expiry coverage directly +1/-1

Run Sanctum token-expiry coverage directly

• Makes the shared database test concrete instead of relying on driver wrappers.

tests/Integration/Sanctum/Database/PersonalAccessTokenExpiryTest.php

DatabaseSessionHandlerTest.phpConsolidate session database tests +10/-1

Consolidate session database tests

• Makes the migrated session test shared across drivers and keeps the native inet column assertion PostgreSQL-only.

tests/Integration/Session/Database/DatabaseSessionHandlerTest.php

TelescopeMigrationTest.phpRun Telescope migration coverage directly +1/-1

Run Telescope migration coverage directly

• Makes the shared migration test concrete for discovery across database suites.

tests/Integration/Telescope/Database/TelescopeMigrationTest.php

ValidationBatchDatabaseCheckerTest.phpRun validation database coverage directly +1/-1

Run validation database coverage directly

• Makes the shared batch-checker test concrete in place of driver wrapper classes.

tests/Integration/Validation/Database/ValidationBatchDatabaseCheckerTest.php

RequireExplicitDoubleModeRuleTest.phpTest explicit Double-mode diagnostics +35/-0

Test explicit Double-mode diagnostics

• Adds a PHPStan RuleTestCase asserting diagnostic locations and guidance for unconfigured Double factories.

tests/PHPStan/Rules/Testing/RequireExplicitDoubleModeRuleTest.php

explicit-double-mode.phpExercise Double-mode flow cases +81/-0

Exercise Double-mode flow cases

• Provides valid and invalid examples covering chains, conditionals, assignments, reassignments, properties, and first-class callables.

tests/PHPStan/Rules/Testing/data/explicit-double-mode.php

HelpersTest.phpStabilize package-version comparison assertions +11/-10

Stabilize package-version comparison assertions

• Uses a fixed virtual package version for equality and ordering checks instead of the checkout-dependent support version.

tests/Testbench/HelpersTest.php

TinkerCasterTest.phpExplain intentionally lenient application Double +1/-1

Explain intentionally lenient application Double

• Places an identifier-specific PHPStan ignore at the factory call for the test that permits unrelated property reads.

tests/Tinker/TinkerCasterTest.php

Documentation (5) +45 / -7
AGENTS.mdDocument integration discovery and test analysis conventions +13/-5

Document integration discovery and test analysis conventions

• Explains shared versus driver-specific database paths, Redis discovery, intentional Double leniency, and the separate test-analysis command.

AGENTS.md

contributions.mdExplain database and Redis test runners +3/-1

Explain database and Redis test runners

• Documents shared database discovery, driver directories, and standalone or cluster Redis commands.

src/docs/contributions.md

static-analysis.mdDocument the test-only Double rule +25/-1

Document the test-only Double rule

• Shows opt-in PHPStan configuration and a reasoned ignore for intentional leniency; corrects the documented PHPStan minimum.

src/docs/static-analysis.md

NodeTestBase.phpClarify MySQL version needs for tree assertions +2/-0

Clarify MySQL version needs for tree assertions

• Documents that countErrors() requires window functions available from MySQL 8.

tests/NestedSet/NodeTestBase.php

ScopedNodeTestBase.phpClarify MySQL version needs for scoped trees +2/-0

Clarify MySQL version needs for scoped trees

• Documents the MySQL 8 window-function requirement of the scoped tree assertion.

tests/NestedSet/ScopedNodeTestBase.php

Other (30) +291 / -186
DockerfileInstall current Composer in CI images +3/-0

Install current Composer in CI images

• Copies the latest stable Composer binary into the image so fresh installs can honor the three-day cooldown policy.

.github/docker/ci/Dockerfile

ci-images.ymlUse locked action tags for image jobs +3/-3

Use locked action tags for image jobs

• Replaces inline commit pins for checkout, registry login, and package cleanup with release tags resolved by the Actions lockfile.

.github/workflows/ci-images.yml

databases-nightly.ymlUse locked checkout tags in nightly database jobs +2/-2

Use locked checkout tags in nightly database jobs

• Switches checkout references from inline commits to the corresponding release tag.

.github/workflows/databases-nightly.yml

databases.ymlUse locked checkout tags in database jobs +9/-9

Use locked checkout tags in database jobs

• Switches checkout references, including the commented example, to release tags.

.github/workflows/databases.yml

doctum.ymlUse locked tags for documentation actions +2/-2

Use locked tags for documentation actions

• Changes checkout and Node setup references to release tags.

.github/workflows/doctum.yml

engine.ymlUse a locked checkout tag for engine tests +1/-1

Use a locked checkout tag for engine tests

• Changes the checkout action reference to its release tag.

.github/workflows/engine.yml

framework.ymlUse a locked checkout tag for framework checks +1/-1

Use a locked checkout tag for framework checks

• Changes the checkout action reference to its release tag.

.github/workflows/framework.yml

grpc.ymlUse locked tags for gRPC actions +2/-2

Use locked tags for gRPC actions

• Changes checkout and Go setup references to release tags.

.github/workflows/grpc.yml

mercure.ymlUse a locked checkout tag for Mercure tests +1/-1

Use a locked checkout tag for Mercure tests

• Changes the checkout action reference to its release tag.

.github/workflows/mercure.yml

publishing-tests.ymlUse a locked checkout tag for publishing checks +1/-1

Use a locked checkout tag for publishing checks

• Changes the checkout action reference to its release tag.

.github/workflows/publishing-tests.yml

redis.ymlDelegate Redis and Valkey suites to a shared runner +6/-62

Delegate Redis and Valkey suites to a shared runner

• Replaces backend-specific test lists with standalone or cluster runner calls and converts checkout references to tags.

.github/workflows/redis.yml

release.ymlUse locked tags for release actions +5/-5

Use locked tags for release actions

• Converts checkout, GitHub Script, auto-commit, and release action references to tags.

.github/workflows/release.yml

reverb.ymlUse a locked checkout tag for Reverb tests +1/-1

Use a locked checkout tag for Reverb tests

• Changes the checkout action reference to its release tag.

.github/workflows/reverb.yml

scout.ymlUse locked checkout tags for Scout jobs +3/-3

Use locked checkout tags for Scout jobs

• Changes checkout references across Scout jobs to release tags.

.github/workflows/scout.yml

skeletons.ymlUse locked tags for skeleton checks +2/-2

Use locked tags for skeleton checks

• Converts checkout and Node setup action references to release tags.

.github/workflows/skeletons.yml

split.ymlUse locked checkout tags for split jobs +2/-2

Use locked checkout tags for split jobs

• Changes both checkout action references to release tags.

.github/workflows/split.yml

static-analysis.ymlVerify the Actions lockfile and analyze tests +24/-1

Verify the Actions lockfile and analyze tests

• Adds a lockfile verification job and a test-rules entry to the PHPStan matrix; checkout uses a release tag.

.github/workflows/static-analysis.yml

submission-maintenance.ymlUse locked tags for submission maintenance +4/-4

Use locked tags for submission maintenance

• Converts checkout, Node setup, and GitHub Script references to release tags.

.github/workflows/submission-maintenance.yml

sync-grpc-health-protocol.ymlUse locked tags for protocol synchronization +2/-2

Use locked tags for protocol synchronization

• Converts checkout and pull-request creation references to release tags.

.github/workflows/sync-grpc-health-protocol.yml

sync-passkeys-aaguids.ymlUse locked tags for AAGUID synchronization +2/-2

Use locked tags for AAGUID synchronization

• Converts checkout and pull-request creation references to release tags.

.github/workflows/sync-passkeys-aaguids.yml

tests.ymlRun framework and package checks in parallel +60/-13

Run framework and package checks in parallel

• Splits code style, framework tests, and package tests into separate jobs, sharing the PHP-version matrix where needed. Also converts action references to tags.

.github/workflows/tests.yml

run-database-tests.shRun shared and driver-specific suites together +7/-65

Run shared and driver-specific suites together

• Sets DB_CONNECTION and invokes one ParaTest process with the shared database suite and the selected driver suite.

bin/run-database-tests.sh

run-redis-tests.shDiscover Redis package tests for standalone and cluster modes +69/-0

Discover Redis package tests for standalone and cluster modes

• Introduces a shared runner that finds package Redis directories, applies special Cache and Queue settings, and runs Cluster serially with its supported core tests.

bin/run-redis-tests.sh

composer.jsonAdd Composer cooldown and test-only analysis command +11/-1

Add Composer cooldown and test-only analysis command

• Sets a three-day cooldown for new dependency resolution and adds analyse:tests to the analysis scripts.

composer.json

composer.jsonDelay fresh AI dogfood dependency resolution +5/-0

Delay fresh AI dogfood dependency resolution

• Adds the three-day Composer cooldown policy.

dogfood/ai/composer.json

composer.jsonDelay fresh MCP dogfood dependency resolution +5/-0

Delay fresh MCP dogfood dependency resolution

• Adds the three-day Composer cooldown policy.

dogfood/mcp/composer.json

composer.jsonResolve the local Testbench checkout consistently +11/-1

Resolve the local Testbench checkout consistently

• Assigns the local components path repository a 0.4.x-dev version for feature-branch installs and adds the Composer cooldown.

dogfood/testbench-package/composer.json

phpstan.tests.neon.distConfigure opt-in PHPStan checks for tests +23/-0

Configure opt-in PHPStan checks for tests

• Registers the explicit Double-mode rule with its own cache and excludes analyzer fixture inputs.

phpstan.tests.neon.dist

phpunit.xml.distDefine shared and per-driver database suites +19/-0

Define shared and per-driver database suites

• Adds suites for direct package database tests and each driver’s subdirectories while preserving the framework suite as the default.

phpunit.xml.dist

composer.jsonAdd dependency cooldown to the application skeleton +5/-0

Add dependency cooldown to the application skeleton

• Sets a three-day Composer cooldown for fresh dependency resolution.

skeletons/hypervel/composer.json

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Database jobs cannot find package tests 🐞 Bug ≡ Correctness
Description
phpunit.xml.dist supplies wildcard strings as `` paths, while the rewritten runner no longer
expands those paths into actual directories. When a database job selects database and its driver
suite, the package directories under tests/Integration are not discovered.
Code

phpunit.xml.dist[R26-28]

+            <directory>./tests/Integration/*/Database</directory>
+            <!-- Only direct package tests are shared. Each driver suite includes its own subdirectories. -->
+            <exclude>./tests/Integration/*/Database/*/</exclude>
Evidence
The runner now invokes only the named XML suites. Those suites specify wildcard directory paths,
whereas package tests reside in concrete directories; the previous runner performed the
package-directory glob expansion in Bash.

bin/run-database-tests.sh[14-25]
phpunit.xml.dist[24-40]
tests/Integration/Auth/Database/EloquentUserProviderCacheTest.php[1-16]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The database suites use wildcard XML directory paths rather than concrete package directories, so the new runner cannot discover package database tests.
## Fix Focus Areas
- phpunit.xml.dist[24-40]
- bin/run-database-tests.sh[14-25]
## Recommended Fix
Expand the shared and driver-specific package paths in the runner and pass concrete test paths to ParaTest, or generate suite entries containing concrete directories. Keep direct package tests shared across drivers and driver subdirectories restricted to their matching backend.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. CI image picks up any future Composer build 🐞 Bug ⛨ Security
Description
The new COPY --from=composer/composer:latest-bin line takes the Composer binary from a mutable
latest tag, with no version or digest pin. Every rebuild of the CI image can quietly switch to a
different Composer, including a new major version or a compromised publish. That binary then
installs dependencies in every test, release and split job, even though the workflows otherwise pin
their tools through the Actions lockfile.
Code

.github/docker/ci/Dockerfile[R139-140]

+# The base image can ship an older Composer than the 2.11+ required for the cooldown.
+COPY --from=composer/composer:latest-bin /composer /usr/local/bin/composer
Evidence
The Dockerfile copies from composer/composer:latest-bin, so the binary is chosen at build time.
ci-images.yml builds and publishes ghcr.io/hypervel/components-ci, and tests.yml, release.yml and
split.yml run composer install inside that image. The PR's stated need is Composer 2.11 or later
for the cooldown. A pinned 2.11-series tag or a digest meets that need without taking whatever is
newest.

.github/docker/ci/Dockerfile[136-144]
.github/workflows/static-analysis.yml[50-63]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The CI image copies Composer from the mutable `composer/composer:latest-bin` tag. Each rebuild can bring in a different Composer, such as a new major version or a tampered image, and that Composer then runs in every CI job.
## Fix Focus Areas
- .github/docker/ci/Dockerfile[139-140]
## Recommended Fix
Replace `latest-bin` with a minimum-satisfying version tag plus a digest, e.g. `COPY --from=composer/composer:2.11-bin@sha256:<digest> /composer /usr/local/bin/composer`. Optionally add `RUN composer --version` to log the chosen version. Let Dependabot's docker ecosystem bump the pin, or bump it by hand.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The reviewed changes appear safe to merge.

Summary

This PR improves service test discovery, splits CI checks, and adds safeguards for dependency updates.

  • Database test runs now combine shared package tests with the matching driver tests.
  • Redis test runs now find package tests under each package's Redis folder.
  • Test analysis now flags doubles that never choose a mode.
  • CI now runs style checks once and test jobs across both PHP versions.
  • GitHub Actions workflows now pair readable version tags with a checked lockfile.
  • Fresh Composer dependency resolution now waits three days for new releases.

No new actionable issues were found in the changes since the previous review. The earlier call-argument finding remains fixed.

Reviews (3) · Last reviewed commit: "Recognize Double mode selection in array..." · Reviewed by Greptile

Tests can set expectations on a double and then pass it to a collaborator by calling strict() or passthru() in an argument. Recognize those calls when PHP evaluates them before handing the double to the collaborator.

Keep reporting cases where another call can use the double first or a conditional expression can skip mode selection. Cover constructor injection, a prior method call, and short-circuiting in the rule fixture.
@binaryfire

Copy link
Copy Markdown
Member Author

I checked both findings. PHPUnit expands the directory patterns in this project. Listing the MariaDB suite includes the shared Auth tests and the MariaDB-specific Pennant tests, and the database jobs ran successfully with those patterns.

The Composer tag is intentional. We want CI image rebuilds to pick up stable Composer releases automatically. The image build prints the chosen version, and subsequent jobs use the copy in that image.

A test helper can set expectations on a double and return it in an array by calling strict() on the array item. PHP evaluates the item before returning the array, so the double already has a mode when the caller receives it.

Reuse the existing expression check for array values and cover the helper pattern in the rule fixture. The checks for prior use and conditional mode selection still apply.
@binaryfire
binaryfire merged commit 6530ccf into 0.4 Nov 18, 2026
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant