Repository navigation
Restore strict expectations in tests converted to Double #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
d021ed3
Release remaining idle database connections after a failure
binaryfire ed41d83
Use Double master for the components test suite
binaryfire 75818e8
Clarify object identity in Double expectations
binaryfire 7f2e365
Match the role event dispatcher call in the listener guard test
binaryfire cf0ff76
Check the container instance passed to queue connections
binaryfire a83cc55
Assert the SQS operation recorded during pooled job deletion
binaryfire fe4b9e9
Remove ineffective empty-handler assertions from SQS batch tests
binaryfire 3582919
Record rate limiter updates after argument matching succeeds
binaryfire 442b49e
Order test traits consistently and clarify the Redis unlink fixture
binaryfire 1d73769
Clarify strict mock conversion and argument capture in Double tests
binaryfire fb57a06
Apply strict Double expectations consistently to ported tests
binaryfire 0341545
Reject unexpected interactions in AI and API client tests
binaryfire 8686592
Preserve authentication collaborator and user identity expectations
binaryfire a924df5
Make broadcasting expectations explicit and capture matched publications
binaryfire d1bf4e1
Verify bus batch dispatch, PostgreSQL inserts and job forwarding
binaryfire 5307fa0
Capture confirmed database, exception and queue interactions
binaryfire 8a025c2
Record search request headers when the client is called
binaryfire 71a84ff
Verify the exact sequence of Redis session connection lookups
binaryfire c073145
Explain policy cache keys and store-wide cache flush events
binaryfire 30627b3
Check the original cache repository and reported broadcast failures
binaryfire e75f392
Tighten Redis cache operation and tag flush tests
binaryfire 1373be1
Tighten cache store and repository double expectations
binaryfire 392fb3c
Reject unexpected calls in connection pool tests
binaryfire 1945068
Check scheduler collaborators and exception identity
binaryfire 0bffe6c
Tighten console command and signal expectations
binaryfire 2020528
Clarify container, cookie and timer test expectations
binaryfire 2f6a35e
Verify reported failures by identity in worker and coroutine tests
binaryfire 095b419
Use strict doubles for Data services and transformers
binaryfire 9e0822a
Express console termination without a command as a no-throw test
binaryfire 2fd1340
Tighten database CLI process and container expectations
binaryfire dc51630
Preserve identity and exercise real Eloquent query forwarding
binaryfire 1c6ccf3
Verify migration and seeding collaborators in strict mode
binaryfire fd6a821
Check the process arguments and SQL used by schema dumps and loads
binaryfire ca223cd
Make schema grammar fixtures describe their database drivers
binaryfire e357b6e
Reject unexpected interactions in database query tests
binaryfire dea8825
Tighten connection, transaction and database lock tests
binaryfire 6bc0947
Reject unexpected calls in diagnostic and service tests
binaryfire 0dbc377
Verify coroutine identity and event forwarding
binaryfire 4df3d30
Tighten filesystem forwarding and failure assertions
binaryfire 8393a23
Make Fortify test collaborators strict
binaryfire d341309
Exercise parallel database guards under isolated worker tokens
binaryfire c6a987c
Verify middleware configuration and exception forwarding
binaryfire 2d4e0d2
Distinguish invalid gRPC durations from overflow in tests
binaryfire 3446c04
Check Horizon supervisor and payload identity
binaryfire f03bbd6
Clarify that assertions are side effects in Double matchers
binaryfire 584d894
Assert on dispatched jobs and events after dispatch
binaryfire c11301e
Check Redis script calls after the expectation matches
binaryfire 4463519
Separate console, filesystem and search assertions from argument matc…
binaryfire 3816499
Exercise permission scopes with integer and UUID fixture keys
binaryfire 3e42ddf
Clarify HTTP and image expectations and failure assertions
binaryfire 7063ed5
Preserve error and instrument identity in pool and telemetry tests
binaryfire d4040b1
Tighten authentication and token-cache test expectations
binaryfire 494f333
Tighten test doubles for mail, notifications and process results
binaryfire 430346f
Verify outbox settlement and worker options at the call boundary
binaryfire c7b0429
Strengthen queue transport and cleanup tests
binaryfire d7d818d
Verify queue command options and worker events
binaryfire e35822b
Reject unexpected calls in queue and integration tests
binaryfire a066f77
Check Redis cluster selection and event registration
binaryfire 72b4f8a
Verify local broadcasts, slot limits and webhook delivery
binaryfire 0c9584a
Tighten routing, authentication and search tests
binaryfire 05a3ec5
Check server, session and failure-reporting interactions
binaryfire c455d15
Check observable support helper and facade behavior
binaryfire 66e64d0
Verify Testbench skip actions and queue payload handling
binaryfire 68a5243
Verify validation query forwarding and rule rejection
binaryfire 47c4b24
Check view rendering and watcher interactions
binaryfire 7860f72
Use a real container in WebSocket callback tests
binaryfire d66ff0c
Merge remote-tracking branch 'origin/0.4' into upstream-sync-2026-11-…
binaryfire 397c5d3
Model healthy Redis clients in release tests
binaryfire c21032f
Model a failed stream read without a timeout
binaryfire c90d570
Complete the Sentry telemetry fixtures
binaryfire 3dab76a
Allow unrelated application reads in the Tinker caster test
binaryfire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When one lease throws a normal cleanup error and a later lease throws
CanceledException, this call replaces the first error without reporting or chaining it. The first error used to reach the caller; now only cancellation escapes. Later normal errors are also silently dropped once a failure is kept.Report each displaced error while still draining every lease.
FailureReporter::preferCancellation()already preserves the same priority while reporting the error that loses it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idle release now tries every lease and then propagates the first failure, with cancellation taking precedence. This follows the cleanup behavior documented in the coroutine guide and used by terminateConnections() and closePools(). The two-lease regression covers both ordinary failure and cancellation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I treated displaced cleanup errors as needing separate reporting, but that does not match the established cleanup contract here:
terminateConnections()andclosePools()also drain all resources, then propagate one selected failure with cancellation taking precedence. The two-lease regression covers that behavior. I withdraw the finding; no additional error reporting is needed.