Skip to content

fix: report false schemas under propertyNames - #303

Merged
jdesrosiers merged 2 commits into
hyperjump-io:mainfrom
MohitSAGAR11:fix-propertynames-false
Nov 15, 2026
Merged

jdesrosiers merged 2 commits into
hyperjump-io:mainfrom
MohitSAGAR11:fix-propertynames-false

Conversation

@MohitSAGAR11

Copy link
Copy Markdown
Contributor

Fixes #302

A false schema under propertyNames now produces an error.

The error index stores property name locations without the * (#*/foo is indexed as #/foo). Keywords already looked errors up that way, but boolean schemas used the location as is, so they found nothing and were treated as passing. The star-stripped location is now computed once in evaluateSchema and used for both.

Tests

Added to src/test-suite/tests/propertyNames.json:

  • propertyNames false
  • propertyNames with a false schema in allOf
  • propertyNames with a $ref to a false schema
  • propertyNames false in anyOf: the first alternative used to be empty.

All 4 fail without the fix (24 runs across dialects). npm test (2200 passed), npm run type-check and npm run lint pass.

MohitSAGAR11 and others added 2 commits November 8, 2026 10:04
The error index stores property name locations without the "*" ("#*/foo" is indexed as "#/foo"). Keywords looked errors up that way, but boolean schemas used the location as is, so a false schema under propertyNames was treated as passing and produced no error.

Fixes hyperjump-io#302
The error index stripped the "*" from property name locations, so "#*/foo"
and "#/foo" shared a key. A false schema under propertyNames was looked up
with the "*" and found nothing (hyperjump-io#302), and when propertyNames and a property
value used the same subschema, an error on one was reported on the other.

Index instance locations as the validator reports them and look them up
exactly. Validators that don't use "*" for property names no longer have
their property name errors found; a fallback or keywordLocation support can
be added if there's demand.

Fixes hyperjump-io#302

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@jdesrosiers jdesrosiers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your tests turned up a bigger problem. Because the error index stripped the *, #*/foo and #/foo shared a key. So when propertyNames and a property value used the same subschema, an error on one was reported on the other.

I pushed a commit that removes the stripping. I kept your tests and added two for the shared-subschema case. The tradeoff is that validators that don't mark property names with * won't have those errors found. We can add a fallback later if anyone needs one.

@jdesrosiers
jdesrosiers merged commit 8729e4f into hyperjump-io:main Nov 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

propertyNames: false produces no error message

2 participants