Repository navigation
fix: report false schemas under propertyNames - #303
Merged
jdesrosiers merged 2 commits intoNov 15, 2026
Merged
Conversation
The error index stores property name locations without the "*" ("#*/foo" is indexed as "#/foo"). Keywords looked errors up that way, but boolean schemas used the location as is, so a false schema under propertyNames was treated as passing and produced no error.
Fixes hyperjump-io#302
The error index stripped the "*" from property name locations, so "#*/foo" and "#/foo" shared a key. A false schema under propertyNames was looked up with the "*" and found nothing (hyperjump-io#302), and when propertyNames and a property value used the same subschema, an error on one was reported on the other. Index instance locations as the validator reports them and look them up exactly. Validators that don't use "*" for property names no longer have their property name errors found; a fallback or keywordLocation support can be added if there's demand. Fixes hyperjump-io#302 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jdesrosiers
approved these changes
Nov 15, 2026
jdesrosiers
left a comment
Collaborator
There was a problem hiding this comment.
Your tests turned up a bigger problem. Because the error index stripped the *, #*/foo and #/foo shared a key. So when propertyNames and a property value used the same subschema, an error on one was reported on the other.
I pushed a commit that removes the stripping. I kept your tests and added two for the shared-subschema case. The tradeoff is that validators that don't mark property names with * won't have those errors found. We can add a fallback later if anyone needs one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302
A
falseschema underpropertyNamesnow produces an error.The error index stores property name locations without the
*(#*/foois indexed as#/foo). Keywords already looked errors up that way, but boolean schemas used the location as is, so they found nothing and were treated as passing. The star-stripped location is now computed once inevaluateSchemaand used for both.Tests
Added to
src/test-suite/tests/propertyNames.json:propertyNames falsepropertyNames with a false schema in allOfpropertyNames with a $ref to a false schemapropertyNames false in anyOf: the first alternative used to be empty.All 4 fail without the fix (24 runs across dialects).
npm test(2200 passed),npm run type-checkandnpm run lintpass.