Repository navigation
Allow omitted gross prices and payment information - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An invoice line with only a net unit price currently fails with
TypeError: can't convert nil into BigDecimal. Both supported XML versions allow the gross unit price to be omitted. Payment means information is also optional, but a missingpayment_textcurrently produces an emptyram:Informationelement.This change accepts a missing
gross_amountwhen no line discount is supplied, omitsGrossPriceProductTradePricein that case, and writesInformationonly whenpayment_textis supplied. A discount still requires a gross amount and raisesSecretariat::ValidationErrorwhen it is missing.Four regression tests cover omitted gross prices in both XML versions, rejection of discounts without a gross price, omitted payment information, and preserved payment information. The generated invoices without gross prices pass the bundled XSD and Schematron validators for ZUGFeRD 1 and 2.
Validation: all 37 tests passed (138 assertions, no failures, errors or skips) on Ruby 3.4.2 with Minitest 5.25.4 and Java 25. StandardRB 1.57.0 reports the same five existing
Style/RedundantStructKeywordInitoffenses on this branch and on upstream commit644acab; this change introduces no additional offenses. Tests were run directly with installed gems. Bundler and other Ruby versions were not checked.