Repository navigation
Conversation
A stray unary plus turned the appended hint into NaN, so an invalid glitch-effect mode logged "…NaN" instead of "mode defaulting to 'sporadic'".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
None.
Summary
When
<glitch-effect>gets an invalidmode, it logs a validation error and falls back tosporadic. The hint about the fallback was never shown: a stray unary plus (message + +'\nmode defaulting…') turned it intoNaN, so the console showed:With the fix it shows:
Testing
Added
glitch-spec.tswith a test that sets an invalid mode and checks the logged message. It fails without the fix and passes with it (Chromium, via web-test-runner).