Skip to content

feat: Add typed issue artifact - #4678

Open
veralizeth wants to merge 9 commits into
google:masterfrom
veralizeth:veralizeth/issues-artifacts-rest
Open

veralizeth wants to merge 9 commits into
google:masterfrom
veralizeth:veralizeth/issues-artifacts-rest

Conversation

@veralizeth

@veralizeth veralizeth commented Oct 27, 2026 •

Copy link
Copy Markdown

Adds typed issue artifact support to IssuesService: list, get, create, update, and delete, plus version history and a pagination iterator.

  • Uses issue-scoped artifact numbers and preserves the {artifact, versions} response.
  • Supports partial updates, including explicit empty strings.
  • Includes tests and generated helpers.

Based on the public GitHub CLI implementation. These endpoints are undocumented, and Link-header pagination is not yet deployed; live compatibility remains unverified.

Validation: Targeted artifact and generated-helper tests passed. No live artifacts were created or modified.

@google-cla

google-cla Bot commented Oct 27, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title Adding typed issue artifact REST support feat: Add typed issue artifact Oct 27, 2026
@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. waiting for signed CLA labels Oct 27, 2026
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (eeb77ef) to head (3d51278).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4678   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         203      204    +1     
  Lines       19027    19089   +62     
=======================================
+ Hits        18769    18831   +62     
  Misses        258      258           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@veralizeth
veralizeth marked this pull request as ready for review October 30, 2026 22:14
@veralizeth

Copy link
Copy Markdown
Author

Hi there! 😄 Could a maintainer please rerun the failed check-openapi job? It failed with a GitHub API 502 while fetching the schema commit. I ran ./script/metadata.sh update-openapi --validate locally and it passed.

@gmlewis

gmlewis commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Hi there! 😄 Could a maintainer please rerun the failed check-openapi job? It failed with a GitHub API 502 while fetching the schema commit. I ran ./script/metadata.sh update-openapi --validate locally and it passed.

I just merged #4693 which should fix the problems you are seeing. You can perform a git pull on the master branch and then go to this PR's branch and git merge master and push the changes to this PR, and hopefully that will resolve the issues you are seeing without having to run update-openapi as that is normally only done by repo maintainers.

Comment thread openapi_operations.yaml Resolved

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @veralizeth!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @Not-Dhananjay-Mishra

Comment thread github/issues_artifacts.go Resolved
Comment thread github/issues_artifacts.go Resolved
Comment thread github/issues_artifacts.go Resolved
Comment thread github/issues_artifacts_test.go Resolved
Comment thread github/issues_artifacts_test.go Resolved
Comment thread github/issues_artifacts_test.go Resolved

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many unnecessary tests in this file. Please follow the same testing approach used in other test files for example github/interactions_user_test.go.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏽‍♀️Thank you for the review! I simplified the service tests and removed redundant cases. Focused JSON tests still cover PATCH omission, empty strings, and nullable fields. Regenerated helpers, race tests, metadata checks, and lint all pass locally.

veralizeth and others added 4 commits November 2, 2026 15:34
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
@veralizeth
veralizeth force-pushed the veralizeth/issues-artifacts-rest branch from b0fa543 to 59c0296 Compare November 3, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants