Repository navigation
fix(telemetry): Record the chunks of a stream cut short before its aggregate - #7938
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…gregate Since the inference span records a stream's `partial=False` aggregate rather than its `partial=True` chunks, a stream that failed before the aggregate arrived recorded no output message at all. Previously its chunks were recorded. When the model call ends with the span still open, the skipped chunks are now recorded, as one output message. Reported in #7815 (comment). Co-authored-by: Max Ind <maxind@google.com> PiperOrigin-RevId: 1012119875
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(telemetry): Record the chunks of a stream cut short before its aggregate
Since the inference span records a stream's
partial=Falseaggregate ratherthan its
partial=Truechunks, a stream that failed before the aggregatearrived recorded no output message at all. Previously its chunks were
recorded.
When the model call ends with the span still open, the skipped chunks are now
recorded, as one output message.
Reported in #7815 (comment).
Co-authored-by: Max Ind maxind@google.com