Repository navigation
fix(task): support raw dict and types.Schema output_schema in FinishTaskTool (#7935) - #7937
Open
mohitdixit02 wants to merge 1 commit into
Open
mohitdixit02 wants to merge 1 commit into
mohitdixit02 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
LlmAgent(mode="task")with a raw dictoutput_schemafails at construction withSchemaError: Unknown schema type: "object"#7935Problem:
When creating an
LlmAgentin task mode (mode="task") with a raw JSON schema dictionary (or agoogle.genai.types.Schemainstance) as itsoutput_schema, agent initialization failed at construction with:pydantic_core._pydantic_core.SchemaError: Unknown schema type: "object"(orPydanticSchemaGenerationError).In
FinishTaskTool.__init__,self._adapter: TypeAdapter[Any] = TypeAdapter(self.output_schema)assumedoutput_schemawas always a Python type or Pydanticmodel. Because
TypeAdapterdoes not accept raw JSON schema dictionaries ortypes.Schemainstances, construction failed before the agent could be used.Solution:
FinishTaskTool.__init__:self._adapter = Nonewhenoutput_schemais a rawdictortypes.Schema, bypassing Pydantic'sTypeAdapter.self.output_schemadirectly toget_output_wrapper_key.FinishTaskTool._get_declaration():self._adapterisNone, obtain the raw schema viacopy.deepcopy(schema_to_json_schema(self.output_schema))to prevent in-place mutation of the user's schema dictionary.FinishTaskTool.run_async():self._adapterisNone, passraw_valuethrough directly, matching the established precedent inSetModelResponseToolandvalidate_node_data.schema_to_json_schema():types.Schemausingmodel_dump(mode="json", exclude_none=True)andlowercase_schema_types.Testing Plan
Unit Tests:
Summary of passed
pytestresults:Manual End-to-End (E2E) Tests:
Verified against the reproduction case with a raw dictionary schema:
Checklist