Repository navigation
fix(runner): raise ValueError in run_async when new_message and invoc… - #7936
Open
mohitdixit02 wants to merge 1 commit into
Open
mohitdixit02 wants to merge 1 commit into
mohitdixit02 wants to merge 1 commit into
Conversation
…ation_id are None (google#7934)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Runner.run_asyncruns anLlmAgentwith neithernew_messagenorinvocation_idinstead of raisingValueError#7934Problem:
Runner.run_asyncdocuments:Raises: ValueError: If the session is not found; If both invocation_id and new_message are None.However, when the root agent is an
LlmAgentor aBaseNode,run_asyncbranched into_run_node_async()and returned before reaching the validation check in_run_with_trace. As a result, callingrun_asyncwithnew_message=Noneandinvocation_id=Noneran without error and called the model with empty contents ([[]]).Solution:
Enforced the
if not invocation_id and new_message is None:check at the entry ofRunner.run_asyncbefore delegating to_run_node_asyncor_run_with_trace.This ensures all root agent types (
LlmAgent,BaseNode, andBaseAgent) uniformly validate the arguments and raiseValueErroras documented.Testing Plan
Unit Tests:
Summary of passed
pytestresults:Manual End-to-End (E2E) Tests:
Verified against the reproduction script in #7934 with an LlmAgent and a recording model:
Checklist