Repository navigation
Conversation
catalog_ai_knowledge stores the organization's AI Knowledge as files: one directory per folder, nested like the folders, each with folder.yaml (name, description, purpose, extraction: model, summary and section instructions, fields, labels; access: all, inherit or workspaces) and documents.yaml (file name, title, and an optional local path or https source). Content never goes into the YAML. load_and_put_declarative_ai_knowledge makes AI Knowledge match the layout: folders are matched by their path of names and created or updated, a missing document is uploaded in parts (any size) or imported by the server, a document in another folder is moved, and delete_missing removes folders that are no longer listed. A subfolder inherits extraction and access unless it sets its own. GoodDataApiClient.request sends authenticated requests to endpoints the generated client does not cover. jira: trivial risk: low Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1981 +/- ##
========================================
Coverage 87.67% 87.68%
========================================
Files 358 360 +2
Lines 29039 29416 +377
========================================
+ Hits 25461 25794 +333
- Misses 3578 3622 +44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, not for review yet. It depends on AI Knowledge API changes that are only on the gdc-nas branch
ptom/ai-knowledge-redesign(nested folders, uploads in parts, imports), which are not on master.What it brings
sdk.catalog_ai_knowledgestores the organization's AI Knowledge as YAML and puts it back:folder.yamlholds what the LLM extracts: model, summary instruction, instruction, labels, and fields (name and instruction), plus access (all,inherit, or{workspaces: [...]}). A subfolder inherits both unless it sets its own.documents.yamllists documents, never their content. A document can name a localpath(uploaded in 8 MiB parts, any size) or an httpssource(the server imports it).store_declarative_ai_knowledge,load_declarative_ai_knowledgeandload_and_put_declarative_ai_knowledge(replace_documents=False, delete_missing=False). Put matches folders by their path of names, creates or updates them, uploads or imports missing documents, and moves documents between folders. Folders are deleted only withdelete_missing.upload_document,import_documentandput_transcript.GoodDataApiClient.requestsends authenticated requests to endpoints the generated client does not cover. The AI Knowledge endpoints are not in the metadata OpenAPI spec.Test plan
tests/catalog/unit_tests/test_ai_knowledge_layout.py: 9 tests against an in-memory fake of the API. They cover the tree on disk, inheritance, refusing inheritance at the top level, the first put and an idempotent second put, moving a document,storekeeping local paths,delete_missing, and an upload in parts.tests/sdkandtests/catalog/unit_testspass (246 tests).🤖 Generated with Claude Code