Repository navigation
[bot] Merge master/0e2b94ad into rel/dev - #1978
Merged
Merged
Conversation
The dashboard filter that references a DATE_RANGE parameter is now deployed on staging as dashboardParameterizedDateFilter. Without it the client's DashboardFilter oneOf rejects any automation whose dashboard export overrides a filter with a parameter, so reading the workspace's declarative automations fails. Regenerating from the staging spec adds DashboardParameterizedDateFilter and makes DashboardFilter accept it. The spec is taken whole, so the regeneration also brings in drift that nothing in the SDK models yet: - author fields and listings on publisher document and page templates; - per-workspace localization statistics with a nullable workspace name; - pageTemplate and documentTemplate in EntityIdentifier and DependentEntitiesNode types; - integer forecast bounds; - the EXPERIMENTAL label dropped from execution parameters. jira: F1-3069 risk: low Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PVUCUDEAhEusJErcYVZ8je
The analytics parameter round trips ran only with a NUMBER parameter, so they are now parametrized over NUMBER and DATE_RANGE. A new test reads a declarative automation whose dashboard export overrides a filter with dashboardParameterizedDateFilter, the way get_declarative_automations reads it, and checks the filter survives. Against the previous client that read failed with no oneOf match. jira: F1-3069 risk: nonprod Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PVUCUDEAhEusJErcYVZ8je
chore(gooddata-api-client): regenerate for date range parameters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1978 +/- ##
========================================
Coverage 87.67% 87.67%
========================================
Files 358 358
Lines 29039 29039
========================================
Hits 25461 25461
Misses 3578 3578 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 0e2b94a (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/44714284664).