Skip to content

fix: propagate errors from repository resource completions - #3584

Closed
pei711 wants to merge 1 commit into
github:mainfrom
pei711:fix/3581-propagate-completion-api-errors
Closed

pei711 wants to merge 1 commit into
github:mainfrom
pei711:fix/3581-propagate-completion-api-errors

Conversation

@pei711

@pei711 pei711 commented Oct 25, 2026

Copy link
Copy Markdown

Summary

Propagate GitHub API errors from branch, commit, and tag resource completions.

Why

Failed lookups currently appear as successful empty results, hiding rate-limit, access, and transport errors. Fixes #3581.

What changed

  • Return errors from ListBranches, ListCommits, and ListTags.
  • Add mocked 403 regression coverage for all three completion paths.

MCP impact

  • No tool or API changes
  • Tool schema or behavior changed
  • New tool added

Resource completions now report GitHub lookup failures instead of successful empty values. No tool schema changed.

Prompts tested (tool changes only)

Not applicable; this change affects resource completions, not tool calls.

Security / limits

  • No security or limits impact
  • Auth / permissions considered
  • Data exposure, filtering, or token/size limits considered

Tool renaming

  • I am renaming tools as part of this PR
  • I am not renaming tools as part of this PR

Lint & tests

  • Linted locally with ./script/lint
  • Tested locally with go test -v ./...

Docs

  • Not needed
  • Updated (README / docs / examples)

AI assistance

OpenAI Codex assisted with the implementation and regression test.

@pei711
pei711 requested a review from a team as a code owner October 25, 2026 17:26
@pei711

pei711 commented Oct 25, 2026

Copy link
Copy Markdown
Author

Closing this duplicate in favor of #3583, which was opened first and covers the same resource completion API errors in the same source and test files. My local tests and lint passed.

@pei711 pei711 closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repository resource completions hide branch, tag, and commit lookup errors

1 participant