Repository navigation
Conversation
Author
|
Closing this duplicate in favor of #3583, which was opened first and covers the same resource completion API errors in the same source and test files. My local tests and lint passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagate GitHub API errors from branch, commit, and tag resource completions.
Why
Failed lookups currently appear as successful empty results, hiding rate-limit, access, and transport errors. Fixes #3581.
What changed
ListBranches,ListCommits, andListTags.MCP impact
Resource completions now report GitHub lookup failures instead of successful empty values. No tool schema changed.
Prompts tested (tool changes only)
Not applicable; this change affects resource completions, not tool calls.
Security / limits
Tool renaming
Lint & tests
./script/lintgo test -v ./...Docs
AI assistance
OpenAI Codex assisted with the implementation and regression test.