Skip to content

feat(service): catch 403 when someone blocks the invitation - #312

Open
nobe4 wants to merge 2 commits into
mainfrom
catch-403
Open

nobe4 wants to merge 2 commits into
mainfrom
catch-403

Conversation

@nobe4

@nobe4 nobe4 commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

This happened just now, and should only warn, but not fail.

This happened just now, and should only warn, but not fail.
Copilot AI auto review requested due to automatic review settings October 28, 2026 20:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the change to handle forbidden organization-membership requests with a warning.

No open issues 🎉

What changed in this PR

Updates organization membership handling so HTTP 403 responses, such as blocked invitations, produce a warning rather than fail the operation.

Changes:

  • Skips retries for Octokit::Forbidden, logs a warning, and returns false.
  • Adds a unit test for the forbidden-response behavior.
  • Bumps the version from 1.2.6 to 1.2.7.
File Description
spec/​unit/​entitlements/​backend/​github_org/​service_spec.rb Tests that a 403 response logs a warning and returns false.
lib/​version.rb Updates the release version to 1.2.7.
lib/​entitlements/​backend/​github_org/​service.rb Handles forbidden membership requests without retrying or raising the error.

Review effort: Balanced (auto)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants