Repository navigation
Conversation
This happened just now, and should only warn, but not fail.
hosom
approved these changes
Oct 28, 2026
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the change to handle forbidden organization-membership requests with a warning.
No open issues 🎉
What changed in this PR
Updates organization membership handling so HTTP 403 responses, such as blocked invitations, produce a warning rather than fail the operation.
Changes:
- Skips retries for
Octokit::Forbidden, logs a warning, and returnsfalse. - Adds a unit test for the forbidden-response behavior.
- Bumps the version from
1.2.6to1.2.7.
| File | Description |
|---|---|
spec/unit/entitlements/backend/github_org/service_spec.rb |
Tests that a 403 response logs a warning and returns false. |
lib/version.rb |
Updates the release version to 1.2.7. |
lib/entitlements/backend/github_org/service.rb |
Handles forbidden membership requests without retrying or raising the error. |
Review effort: Balanced (auto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happened just now, and should only warn, but not fail.