Repository navigation
Parameterize survey database writes - #72
Merged
Merged
Conversation
Co-authored-by: mageroni <107436170+mageroni@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Hard-coded parameter placeholders make the tests brittle to column reordering and leave the INSERT column-to-value mapping unverified.
1 open issue
What changed in this PR
This PR reduces SQL injection risk in survey database writes by replacing interpolated values with bound parameters.
Changes:
- Parameterize INSERT and UPDATE values and issue IDs, using an allowlist for column names.
- Add regression tests confirming SQL-like comments remain parameter data in both write paths.
| File | Description |
|---|---|
test/index.test.js |
Extend database mocks and test parameterized survey inserts and updates. |
index.js |
Add the column allowlist and bind survey write parameters through mssql.Request. |
Review effort: Max (auto)
Refactor query validation to extract comment parameter and check format. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Survey issue bodies and comments were interpolated into SQL statements, creating an injection risk in both INSERT and UPDATE operations.
mssql.Request.input; use an allowlist for column names.