Skip to content

Update vulnerable transitive dependencies - #70

Merged
mageroni merged 3 commits into
mainfrom
copilot/fix-msal-node-vulnerability
Nov 12, 2026
Merged

mageroni merged 3 commits into
mainfrom
copilot/fix-msal-node-vulnerability

Conversation

Copilot AI commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Remediate the MSAL authorization-code flow advisory and four additional Dependabot alerts by updating affected transitive dependencies to patched versions.

  • Dependency updates

    • @azure/msal-node → 7.1.0; @azure/identity → 4.14.1
    • OpenTelemetry MySQL → 0.67.0 and PostgreSQL → 0.73.0; Azure Monitor OpenTelemetry → 1.20.0
    • brace-expansion → 1.1.21; fast-copy → 4.1.0
  • Reachability Assessment

    • MSAL auth-code flow — not reachable; high confidence. acquireTokenByCode is not called; MSAL is only included transitively through Application Insights/Identity.
    • MySQL/PostgreSQL username spans — not reachable; high confidence. The app uses MSSQL and has no MySQL or PostgreSQL drivers.
    • Brace expansion — not production-reachable; high confidence. It is a dev-only dependency of minimatch.
    • Deep-copy stack exhaustion — reachability uncertain; low confidence. fast-copy is transitively included with production logging/telemetry dependencies. The app logs and sends telemetry, but does not call its copy API directly; exposure may depend on whether deeply nested attacker-controlled values reach that path.
Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>MSAL Node authorization code flow may disclose parameters to an attacker-controlled endpoint</alert_title>
<alert_description>### Impact

Origin validation error in Microsoft Authentication Library (MSAL) for Node.js allows an unauthorized attacker to disclose information over a network. This affects the auth_code flow.

Patches

Version 7.1.0 and higher are patched.

Workarounds

Ensure you pass in only the auth_code to to acquireTokenByCode</alert_description>

high
GHSA-xcx6-jx8p-x3h5, CVE-2026-109461
@azure/msal-node
npm
<vulnerable_versions>5.2.2</vulnerable_versions>
<patched_version>7.1.0</patched_version>
<manifest_path>package-lock.json</manifest_path>

https://github.com/AzureAD/microsoft-authentication-library-for-js/security/advisories/GHSA-xcx6-jx8p-x3h5 https://nvd.nist.gov/vuln/detail/CVE-2026-109461 https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/8901 https://github.com/AzureAD/microsoft-authentication-library-for-js/commit/f550958586475dbfeb1cd44be14a2d653728850e https://github.com/AzureAD/microsoft-authentication-library-for-js/releases/tag/msal-node-v7.1.0 https://msrc.microsoft.com/update-guide/vulnerability/CVE-2026-109461 https://github.com/advisories/GHSA-xcx6-jx8p-x3h5

<agent_instructions>Also solve the other following alerts:
https://github.com/github/copilot-survey-engine/security/dependabot/72
https://github.com/github/copilot-survey-engine/security/dependabot/73
https://github.com/github/copilot-survey-engine/security/dependabot/70
https://github.com/github/copilot-survey-engine/security/dependabot/71</agent_instructions>

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attempting increasingly complex workarounds. After updating, check the lock file to confirm the package no longer resolves to a version in the vulnerable range. Keep changes minimal and tightly scoped. Ensure tests, build, type checking, and linting all pass after your changes. If there are any test, lint, or ty...

  • Resolves github/copilot-survey-engine alert #76

Co-authored-by: mageroni <107436170+mageroni@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix MSAL Node authorization code flow vulnerability Update vulnerable transitive dependencies Nov 10, 2026
Copilot AI requested a review from mageroni November 10, 2026 23:38
…fix-msal-node-vulnerability

# Conflicts:
#	package-lock.json

Co-authored-by: mageroni <107436170+mageroni@users.noreply.github.com>
@mageroni
mageroni marked this pull request as ready for review November 12, 2026 16:18
Copilot AI adaptive review requested due to automatic review settings November 12, 2026 16:18
@mageroni
mageroni merged commit 740883b into main Nov 12, 2026
8 checks passed
@mageroni
mageroni deleted the copilot/fix-msal-node-vulnerability branch November 12, 2026 16:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A critical active finding remains because the dependency overrides require Node >=22 while the project and production Dockerfile still target Node 18, leaving the production dependency set unsupported.

1 open issue
What changed in this PR

Updates transitive npm dependencies to address the reported security advisories across Azure authentication, OpenTelemetry instrumentation, brace expansion, and deep-copy functionality.

Changes:

  • Adds npm overrides for patched Azure, OpenTelemetry, brace-expansion, and fast-copy versions.
  • Regenerates the lockfile with updated dependency resolutions and integrity metadata.
  • The selected Azure dependencies require Node.js 22, while the project still declares and deploys Node.js 18.
File Description
package.json Adds npm overrides for the patched transitive Azure, OpenTelemetry, and utility dependency versions.
package-lock.json Records the updated Azure, OpenTelemetry, and utility dependency resolutions and dependency tree.

Review effort: Lite (auto)

Comment thread package.json
Comment on lines +36 to +37
"@azure/identity": "4.14.1",
"@azure/monitor-opentelemetry": "1.20.0",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants